RANGER-521: audit logs for grant/revoke show empty resource name
Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/3683ac0f Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/3683ac0f Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/3683ac0f Branch: refs/heads/ranger-0.5 Commit: 3683ac0f7279c8c71bfadff3abb93bc8aa281fe5 Parents: cfc0f39 Author: Madhan Neethiraj <[email protected]> Authored: Thu Jun 4 08:46:09 2015 -0700 Committer: Madhan Neethiraj <[email protected]> Committed: Thu Jun 4 08:46:09 2015 -0700 ---------------------------------------------------------------------- .../org/apache/ranger/plugin/service/RangerBasePlugin.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/3683ac0f/agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java ---------------------------------------------------------------------- diff --git a/agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java b/agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java index 095eafb..404108d 100644 --- a/agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java +++ b/agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java @@ -268,9 +268,7 @@ public class RangerBasePlugin { } private void auditGrantRevoke(GrantRevokeRequest request, String action, boolean isSuccess, RangerAccessResultProcessor resultProcessor) { - RangerPolicyEngine policyEngine = this.policyEngine; - - if(request != null && resultProcessor != null && policyEngine != null) { + if(request != null && resultProcessor != null) { RangerAccessRequestImpl accessRequest = new RangerAccessRequestImpl(); accessRequest.setResource(new RangerAccessResourceImpl(request.getResource())); @@ -283,7 +281,7 @@ public class RangerBasePlugin { accessRequest.setSessionId(request.getSessionId()); // call isAccessAllowed() to determine if audit is enabled or not - RangerAccessResult accessResult = policyEngine.isAccessAllowed(accessRequest, null); + RangerAccessResult accessResult = isAccessAllowed(accessRequest, null); if(accessResult != null && accessResult.getIsAudited()) { accessRequest.setAccessType(action);
