Repository: incubator-ranger Updated Branches: refs/heads/master b2eb42532 -> b1e1135b6
RANGER-845 Replace StringBuffer with StringBuilder Signed-off-by: Alok Lal <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/b1e1135b Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/b1e1135b Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/b1e1135b Branch: refs/heads/master Commit: b1e1135b65ad51bcc3a7ce54ae74f1696932220f Parents: b2eb425 Author: Colm O hEigeartaigh <[email protected]> Authored: Fri Feb 12 14:45:49 2016 +0000 Committer: Alok Lal <[email protected]> Committed: Mon Feb 22 09:01:15 2016 -0800 ---------------------------------------------------------------------- .../plugin/policyevaluator/RangerDefaultPolicyEvaluator.java | 2 +- .../RangerDefaultPolicyResourceMatcher.java | 2 +- .../main/java/org/apache/ranger/credentialapi/buildks.java | 2 +- .../org/apache/util/outputformatter/DefaultFormatter.java | 6 +++--- jisql/src/main/java/org/apache/util/sql/Jisql.java | 6 +++--- jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java | 4 ++-- .../apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java | 8 ++++---- .../src/main/java/org/apache/ranger/common/StringUtil.java | 2 +- .../src/main/java/org/apache/ranger/db/XXResourceDao.java | 4 ++-- .../main/java/org/apache/ranger/service/XAgentService.java | 2 +- .../java/org/apache/ranger/service/XResourceService.java | 2 +- .../org/apache/ranger/tagsync/process/TagSyncConfig.java | 2 +- 12 files changed, 21 insertions(+), 21 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java ---------------------------------------------------------------------- diff --git a/agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java b/agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java index 8107459..6171015 100644 --- a/agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java +++ b/agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java @@ -72,7 +72,7 @@ public class RangerDefaultPolicyEvaluator extends RangerAbstractPolicyEvaluator LOG.debug("==> RangerDefaultPolicyEvaluator.init()"); } - StringBuffer perfTagBuffer = new StringBuffer(); + StringBuilder perfTagBuffer = new StringBuilder(); if (policy != null) { perfTagBuffer.append("policyId=").append(policy.getId()).append(", policyName=").append(policy.getName()); } http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java ---------------------------------------------------------------------- diff --git a/agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java b/agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java index e6f61d5..5031462 100644 --- a/agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java +++ b/agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java @@ -144,7 +144,7 @@ public class RangerDefaultPolicyResourceMatcher implements RangerPolicyResourceM if(matchers == null) { Set<String> policyResourceKeys = policyResources == null ? null : policyResources.keySet(); - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); if (CollectionUtils.isNotEmpty(policyResourceKeys)) { for (String policyResourceKeyName : policyResourceKeys) { sb.append(" ").append(policyResourceKeyName).append(" "); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java ---------------------------------------------------------------------- diff --git a/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java b/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java index b4c856b..499c1c4 100644 --- a/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java +++ b/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java @@ -360,7 +360,7 @@ public class buildks { { String debugOption = System.getProperty("debug") ; if (debugOption != null && "TRUE".equalsIgnoreCase(debugOption)) { - StringBuffer tempBuffer=new StringBuffer(""); + StringBuilder tempBuffer=new StringBuilder(""); if(args!=null && args.length>0){ for(int index=0;index<args.length;index++){ tempBuffer.append(args[index]+" "); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/jisql/src/main/java/org/apache/util/outputformatter/DefaultFormatter.java ---------------------------------------------------------------------- diff --git a/jisql/src/main/java/org/apache/util/outputformatter/DefaultFormatter.java b/jisql/src/main/java/org/apache/util/outputformatter/DefaultFormatter.java index a9fac4d..a3bb626 100644 --- a/jisql/src/main/java/org/apache/util/outputformatter/DefaultFormatter.java +++ b/jisql/src/main/java/org/apache/util/outputformatter/DefaultFormatter.java @@ -247,7 +247,7 @@ public class DefaultFormatter implements JisqlFormatter { return s.substring(0, width); int fillWidth = width - len; - StringBuffer fill = new StringBuffer(fillWidth); + StringBuilder fill = new StringBuilder(fillWidth); for (int i = 0; i < fillWidth; ++i) fill.append(spacer); if (leftJustify) @@ -283,7 +283,7 @@ public class DefaultFormatter implements JisqlFormatter { if (len >= width) width = len; - StringBuffer fill = new StringBuffer(width); + StringBuilder fill = new StringBuilder(width); for (int i = 0; i < width; ++i) fill.append('-'); @@ -329,7 +329,7 @@ public class DefaultFormatter implements JisqlFormatter { } int fillWidth = width - len; - StringBuffer fill = new StringBuffer(fillWidth); + StringBuilder fill = new StringBuilder(fillWidth); for (int i = 0; i < fillWidth; ++i) fill.append(spacer); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/jisql/src/main/java/org/apache/util/sql/Jisql.java ---------------------------------------------------------------------- diff --git a/jisql/src/main/java/org/apache/util/sql/Jisql.java b/jisql/src/main/java/org/apache/util/sql/Jisql.java index 2b8fc76..d00b131 100644 --- a/jisql/src/main/java/org/apache/util/sql/Jisql.java +++ b/jisql/src/main/java/org/apache/util/sql/Jisql.java @@ -365,7 +365,7 @@ public class Jisql { Statement statement = null; ResultSet resultSet = null; ResultSetMetaData resultSetMetaData = null; - StringBuffer query = null; + StringBuilder query = null; if (inputFileName != null) { try { @@ -390,7 +390,7 @@ public class Jisql { while (true) { int linecount = 1; - query = new StringBuffer(); + query = new StringBuilder(); try { if ((inputFileName == null) && (inputQuery == null)) @@ -417,7 +417,7 @@ public class Jisql { } if (line.equals("reset")) { - query = new StringBuffer(); + query = new StringBuilder(); break; } trimmedLine=line.trim(); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java ---------------------------------------------------------------------- diff --git a/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java b/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java index c41c95e..c072142 100644 --- a/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java +++ b/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java @@ -126,13 +126,13 @@ public class MySQLPLRunner { */ private void runScript(Connection conn, Reader reader) throws IOException, SQLException { - StringBuffer command = null; + StringBuilder command = null; try { LineNumberReader lineReader = new LineNumberReader(reader); String line = null; while ((line = lineReader.readLine()) != null) { if (command == null) { - command = new StringBuffer(); + command = new StringBuilder(); } String trimmedLine = line.trim(); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java ---------------------------------------------------------------------- diff --git a/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java b/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java index 2a3c149..6352fbc 100644 --- a/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java +++ b/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java @@ -40,9 +40,9 @@ public class KMSMDCFilter implements Filter { private static class Data { private UserGroupInformation ugi; private String method; - private StringBuffer url; + private String url; - private Data(UserGroupInformation ugi, String method, StringBuffer url) { + private Data(UserGroupInformation ugi, String method, String url) { this.ugi = ugi; this.method = method; this.url = url; @@ -60,7 +60,7 @@ public class KMSMDCFilter implements Filter { } public static String getURL() { - return DATA_TL.get().url.toString(); + return DATA_TL.get().url; } @Override @@ -80,7 +80,7 @@ public class KMSMDCFilter implements Filter { if (queryString != null) { requestURL.append("?").append(queryString); } - DATA_TL.set(new Data(ugi, method, requestURL)); + DATA_TL.set(new Data(ugi, method, requestURL.toString())); chain.doFilter(request, response); } finally { DATA_TL.remove(); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/security-admin/src/main/java/org/apache/ranger/common/StringUtil.java ---------------------------------------------------------------------- diff --git a/security-admin/src/main/java/org/apache/ranger/common/StringUtil.java b/security-admin/src/main/java/org/apache/ranger/common/StringUtil.java index f5990b4..c292fec 100644 --- a/security-admin/src/main/java/org/apache/ranger/common/StringUtil.java +++ b/security-admin/src/main/java/org/apache/ranger/common/StringUtil.java @@ -90,7 +90,7 @@ public class StringUtil implements Serializable { return null; } str = str.trim().toLowerCase(); - StringBuffer result = new StringBuffer(str.length()); + StringBuilder result = new StringBuilder(str.length()); boolean makeUpper = true; boolean lastCharSpace = true; for (int c = 0; c < str.length(); c++) { http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java ---------------------------------------------------------------------- diff --git a/security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java b/security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java index 020a76c..0ca4d42 100644 --- a/security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java +++ b/security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java @@ -219,7 +219,7 @@ public class XXResourceDao extends BaseDao<XXResource> { return null; } try { - StringBuffer query = new StringBuffer( + StringBuilder query = new StringBuilder( "SELECT obj FROM XXResource obj WHERE obj.assetId=" + assetId); String whereClause = makeWhereCaluseForResourceType(resourceType); @@ -235,7 +235,7 @@ public class XXResourceDao extends BaseDao<XXResource> { } private String makeWhereCaluseForResourceType(List<Integer> resourceTypes) { - StringBuffer whereClause = new StringBuffer(); + StringBuilder whereClause = new StringBuilder(); if (resourceTypes != null && resourceTypes.size() != 0) { for (int i = 0; i < resourceTypes.size() - 1; i++) { http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/security-admin/src/main/java/org/apache/ranger/service/XAgentService.java ---------------------------------------------------------------------- diff --git a/security-admin/src/main/java/org/apache/ranger/service/XAgentService.java b/security-admin/src/main/java/org/apache/ranger/service/XAgentService.java index f954f0e..8fbb74b 100644 --- a/security-admin/src/main/java/org/apache/ranger/service/XAgentService.java +++ b/security-admin/src/main/java/org/apache/ranger/service/XAgentService.java @@ -105,7 +105,7 @@ public class XAgentService { } private String bulidWhereClause(SearchCriteria searchCriteria) { - StringBuffer whereClause = new StringBuffer(); + StringBuilder whereClause = new StringBuilder(); Date startDate = (Date) searchCriteria.getParamValue("startDate"); Date endDate = (Date) searchCriteria.getParamValue("endDate"); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java ---------------------------------------------------------------------- diff --git a/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java b/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java index 28e9282..63bc0fa 100644 --- a/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java +++ b/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java @@ -513,7 +513,7 @@ public class XResourceService extends pathList.add(fileSeparator); } - StringBuffer path = new StringBuffer(); + StringBuilder path = new StringBuilder(); for (int i = 1; i < policyPathParts.length - 1; i++) { path.append(fileSeparator + policyPathParts[i]); pathList.add(path.toString()); http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/b1e1135b/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java ---------------------------------------------------------------------- diff --git a/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java b/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java index b7ea2ad..ed8679a 100644 --- a/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java +++ b/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java @@ -158,7 +158,7 @@ public class TagSyncConfig extends Configuration { @Override public String toString() { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("DEFAULT_CONFIG_FILE=").append(DEFAULT_CONFIG_FILE).append(", ") .append("CONFIG_FILE=").append(CONFIG_FILE).append("\n\n");
