Repository: incubator-ranger Updated Branches: refs/heads/master 9a424cece -> e15662509
RANGER-855 - Fix "BooleanInstantiation" issues Signed-off-by: Alok Lal <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/e1566250 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/e1566250 Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/e1566250 Branch: refs/heads/master Commit: e15662509f2d911b637918e155e4133899839e78 Parents: 9a424ce Author: Colm O hEigeartaigh <[email protected]> Authored: Thu Mar 24 11:38:13 2016 +0000 Committer: Alok Lal <[email protected]> Committed: Thu Mar 24 18:28:07 2016 -0700 ---------------------------------------------------------------------- dev-support/ranger-pmd-ruleset.xml | 1 - .../src/main/java/org/apache/ranger/common/RESTErrorUtil.java | 2 +- .../security/web/filter/RangerSecurityContextFormationFilter.java | 2 +- security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/e1566250/dev-support/ranger-pmd-ruleset.xml ---------------------------------------------------------------------- diff --git a/dev-support/ranger-pmd-ruleset.xml b/dev-support/ranger-pmd-ruleset.xml index da0c1ec..405c570 100644 --- a/dev-support/ranger-pmd-ruleset.xml +++ b/dev-support/ranger-pmd-ruleset.xml @@ -28,7 +28,6 @@ <exclude name="AvoidBranchingStatementAsLastInLoop" /> <exclude name="AvoidThreadGroup" /> <exclude name="AvoidUsingHardCodedIP" /> - <exclude name="BooleanInstantiation" /> <exclude name="ClassCastExceptionWithToArray" /> <exclude name="CollapsibleIfStatements" /> <exclude name="DoubleCheckedLocking" /> http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/e1566250/security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java ---------------------------------------------------------------------- diff --git a/security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java b/security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java index c911c1f..bf53db2 100644 --- a/security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java +++ b/security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java @@ -368,7 +368,7 @@ public class RESTErrorUtil { if (stringUtil.isEmpty(value)) { return null; } else { - return new Boolean(value.trim()); + return Boolean.valueOf(value.trim()); } } catch (Throwable t) { throw createRESTException(errorMessage, messageEnum, objectId, http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/e1566250/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java ---------------------------------------------------------------------- diff --git a/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java b/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java index 3c0eb95..2102768 100644 --- a/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java +++ b/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java @@ -131,7 +131,7 @@ public class RangerSecurityContextFormationFilter extends GenericFilterBean { if (userSession != null) { Object ssoEnabledObj = request.getAttribute("ssoEnabled"); - Boolean ssoEnabled = ssoEnabledObj != null ? new Boolean(String.valueOf(ssoEnabledObj)) : PropertiesUtil.getBooleanProperty("ranger.sso.enabled", false); + Boolean ssoEnabled = ssoEnabledObj != null ? Boolean.valueOf(String.valueOf(ssoEnabledObj)) : PropertiesUtil.getBooleanProperty("ranger.sso.enabled", false); userSession.setSSOEnabled(ssoEnabled); if (userSession.getClientTimeOffsetInMinute() == 0) { http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/e1566250/security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java ---------------------------------------------------------------------- diff --git a/security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java b/security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java index 405f7c4..1c96da2 100644 --- a/security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java +++ b/security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java @@ -571,6 +571,6 @@ public class VXPolicy extends VXDataObject implements java.io.Serializable { this.setResourceName(null); this.setRepositoryType(null); this.setVersion(null); - this.setIsRecursive(new Boolean(null)); + this.setIsRecursive(Boolean.FALSE); } }
