Repository: incubator-ranger Updated Branches: refs/heads/master ab131efd3 -> ae5395855
RANGER-1095 - Invert authorization logic in RangerSolrAuthorizer Reviewed by Don Bosco Durai Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/ae539585 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/ae539585 Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/ae539585 Branch: refs/heads/master Commit: ae53958559129da24915f344f6c3cfa89284faaa Parents: ab131ef Author: Colm O hEigeartaigh <[email protected]> Authored: Thu Jul 21 10:39:41 2016 +0100 Committer: Colm O hEigeartaigh <[email protected]> Committed: Thu Jul 21 10:39:41 2016 +0100 ---------------------------------------------------------------------- .../authorization/solr/authorizer/RangerSolrAuthorizer.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/ae539585/plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java ---------------------------------------------------------------------- diff --git a/plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java b/plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java index 4376908..d8e24ba 100644 --- a/plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java +++ b/plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java @@ -152,7 +152,7 @@ public class RangerSolrAuthorizer implements AuthorizationPlugin { */ @Override public AuthorizationResponse authorize(AuthorizationContext context) { - boolean isDenied = false; + boolean isDenied = true; try { if (logger.isDebugEnabled()) { @@ -201,6 +201,8 @@ public class RangerSolrAuthorizer implements AuthorizationPlugin { isDenied = true; // rejecting on first failure break; + } else { + isDenied = false; } } } finally {
