Repository: incubator-ranger Updated Branches: refs/heads/master 4a565dfbc -> 68898eff0
RANGER-1282:Good coding practice in Ranger recommended by static code analysis Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/68898eff Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/68898eff Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/68898eff Branch: refs/heads/master Commit: 68898eff03f33e6cf1468c72f32cb4ec2b2d4559 Parents: 4a565df Author: rmani <rm...@hortonworks.com> Authored: Tue Dec 27 11:00:43 2016 -0800 Committer: rmani <rm...@hortonworks.com> Committed: Tue Dec 27 11:00:43 2016 -0800 ---------------------------------------------------------------------- .../org/apache/ranger/services/storm/client/StormClient.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/68898eff/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java ---------------------------------------------------------------------- diff --git a/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java b/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java index 0e9c0df..e752362 100644 --- a/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java +++ b/storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java @@ -89,8 +89,6 @@ public class StormClient { topologyNameMatching); final String errMsg = errMessage; - List<String> ret = new ArrayList<String>(); - PrivilegedAction<ArrayList<String>> topologyListGetter = new PrivilegedAction<ArrayList<String>>() { @Override public ArrayList<String> run() { @@ -179,11 +177,10 @@ public class StormClient { return lret; } }; - + List<String> ret = null; try { ret = executeUnderKerberos(this.userName, this.password, this.lookupPrincipal, this.lookupKeytab, this.nameRules, topologyListGetter); } catch (IOException e) { - ret=null; LOG.error("Unable to get Topology list from [" + stormUIUrl + "]", e); }
