[ratis] branch master updated: RATIS-1396. Reduce lock contention in RaftServerImpl::replyPendingRequest. (#494)

[shashikant]

This is an automated email from the ASF dual-hosted git repository.

shashikant pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ratis.git


The following commit(s) were added to refs/heads/master by this push:
     new 519acad  RATIS-1396. Reduce lock contention in 
RaftServerImpl::replyPendingRequest. (#494)
519acad is described below

commit 519acad397a10541a5f3fdf376cb44886c22febf
Author: Tsz-Wo Nicholas Sze <szets...@apache.org>
AuthorDate: Fri Sep 17 00:26:17 2021 +0800

    RATIS-1396. Reduce lock contention in RaftServerImpl::replyPendingRequest. 
(#494)
---
 .../main/java/org/apache/ratis/server/impl/RaftServerImpl.java | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git 
a/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java 
b/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
index 11b7602..5db2690 100644
--- 
a/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
+++ 
b/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
@@ -732,9 +732,7 @@ class RaftServerImpl implements RaftServer.Division,
   }
 
   void stepDownOnJvmPause() {
-    if (getInfo().isLeader()) {
-      role.getLeaderState().ifPresent(leader -> 
leader.submitStepDownEvent(LeaderState.StepDownReason.JVM_PAUSE));
-    }
+    role.getLeaderState().ifPresent(leader -> 
leader.submitStepDownEvent(LeaderState.StepDownReason.JVM_PAUSE));
   }
 
   private RaftClientRequest 
filterDataStreamRaftClientRequest(RaftClientRequest request)
@@ -1690,11 +1688,7 @@ class RaftServerImpl implements RaftServer.Division,
       }
 
       // update pending request
-      synchronized (RaftServerImpl.this) {
-        if (getInfo().isLeader()) {
-          role.getLeaderState().ifPresent(leader -> 
leader.replyPendingRequest(logIndex, r));
-        }
-      }
+      role.getLeaderState().ifPresent(leader -> 
leader.replyPendingRequest(logIndex, r));
       cacheEntry.updateResult(r);
     });
   }