This is an automated email from the ASF dual-hosted git repository.
szetszwo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-ratis.git
The following commit(s) were added to refs/heads/master by this push:
new 61bae7d RATIS-476. checkstyle SuppressionCommentFilter and
SuppressWithNearbyCommentFilter are in wrong module. Contributed by Dinesh
Chitlangia
61bae7d is described below
commit 61bae7d81ee6439b891d852496004e8cd98ea981
Author: Tsz Wo Nicholas Sze <[email protected]>
AuthorDate: Fri Jan 25 12:12:52 2019 -0800
RATIS-476. checkstyle SuppressionCommentFilter and
SuppressWithNearbyCommentFilter are in wrong module. Contributed by Dinesh
Chitlangia
---
dev-support/checkstyle.xml | 4 ++--
pom.xml | 9 +++++++++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/dev-support/checkstyle.xml b/dev-support/checkstyle.xml
index 7fdc712..5e52d98 100644
--- a/dev-support/checkstyle.xml
+++ b/dev-support/checkstyle.xml
@@ -56,8 +56,6 @@
<property name="fileExtensions" value="java, properties, xml"/>
<module name="SuppressWarningsFilter"/>
- <module name="SuppressionCommentFilter"/>
- <module name="SuppressWithNearbyCommentFilter"/>
<!-- Checks that a package-info.java file exists for each package. -->
<!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage -->
@@ -97,6 +95,8 @@
<module name="TreeWalker">
<module name="SuppressWarningsHolder"/>
+ <module name="SuppressionCommentFilter"/>
+ <module name="SuppressWithNearbyCommentFilter"/>
<!-- Checks for Javadoc comments. -->
<!-- See http://checkstyle.sf.net/config_javadoc.html -->
diff --git a/pom.xml b/pom.xml
index 4d4282d..ded40d7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -188,6 +188,8 @@
<test.exclude.pattern>_</test.exclude.pattern>
<!-- number of threads/forks to use when running tests in parallel, see
parallel-tests profile -->
<testsThreadCount>4</testsThreadCount>
+
+ <checkstyle.version>8.16</checkstyle.version>
</properties>
<dependencyManagement>
@@ -680,6 +682,13 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven-checkstyle-plugin.version}</version>
+ <dependencies>
+ <dependency>
+ <groupId>com.puppycrawl.tools</groupId>
+ <artifactId>checkstyle</artifactId>
+ <version>${checkstyle.version}</version>
+ </dependency>
+ </dependencies>
<configuration>
<configLocation>${basedir}/../dev-support/checkstyle.xml</configLocation>
<failOnViolation>false</failOnViolation>
