[incubator-ratis] branch master updated: RATIS-694. Fix checkstyle violations in ratis-metrics. Contributed by Dinesh Chitlangia

[szetszwo]

This is an automated email from the ASF dual-hosted git repository.

szetszwo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-ratis.git


The following commit(s) were added to refs/heads/master by this push:
     new debf50a  RATIS-694. Fix checkstyle violations in ratis-metrics.  
Contributed by Dinesh Chitlangia
debf50a is described below

commit debf50acc42d0d39b8d5e3396ec7eba2ebabf963
Author: Tsz Wo Nicholas Sze <szets...@apache.org>
AuthorDate: Thu Oct 24 09:00:10 2019 -0700

    RATIS-694. Fix checkstyle violations in ratis-metrics.  Contributed by 
Dinesh Chitlangia
---
 .../main/java/org/apache/ratis/metrics/MetricRegistriesLoader.java  | 4 ++--
 .../src/main/java/org/apache/ratis/metrics/MetricRegistryInfo.java  | 6 +++---
 .../java/org/apache/ratis/metrics/impl/RatisMetricRegistryImpl.java | 2 +-
 .../src/main/java/org/apache/ratis/metrics/impl/RefCountingMap.java | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistriesLoader.java
 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistriesLoader.java
index 9e414ad..e2da686 100644
--- 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistriesLoader.java
+++ 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistriesLoader.java
@@ -32,7 +32,7 @@ import org.slf4j.LoggerFactory;
 public final class MetricRegistriesLoader {
   private static final Logger LOG = 
LoggerFactory.getLogger(MetricRegistries.class);
 
-  private static final String defaultClass
+  private static final String DEFAULT_CLASS
       = "org.apache.ratis.metrics.impl.MetricRegistriesImpl";
 
   private MetricRegistriesLoader() {
@@ -65,7 +65,7 @@ public final class MetricRegistriesLoader {
       return impl;
     } else if (availableImplementations.isEmpty()) {
       try {
-        return 
ReflectionUtils.newInstance((Class<MetricRegistries>)Class.forName(defaultClass));
+        return 
ReflectionUtils.newInstance((Class<MetricRegistries>)Class.forName(DEFAULT_CLASS));
       } catch (ClassNotFoundException e) {
         throw new RuntimeException(e);
       }
diff --git 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistryInfo.java 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistryInfo.java
index 6b6435f..1d9f2f1 100644
--- 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistryInfo.java
+++ 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/MetricRegistryInfo.java
@@ -30,9 +30,9 @@ import com.codahale.metrics.MetricRegistry;
  */
 public class MetricRegistryInfo {
 
-  protected final String prefix;
-  protected final String metricsDescription;
-  protected final String metricsComponentName;
+  private final String prefix;
+  private final String metricsDescription;
+  private final String metricsComponentName;
   private final String fullName;
   private final String applicationName;
 
diff --git 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RatisMetricRegistryImpl.java
 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RatisMetricRegistryImpl.java
index a2575d5..03af689 100644
--- 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RatisMetricRegistryImpl.java
+++ 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RatisMetricRegistryImpl.java
@@ -38,7 +38,7 @@ import 
org.apache.ratis.thirdparty.com.google.common.annotations.VisibleForTesti
  * Custom implementation of {@link MetricRegistry}.
  */
 public class RatisMetricRegistryImpl implements RatisMetricRegistry {
-  MetricRegistry metricRegistry = new MetricRegistry();
+  private MetricRegistry metricRegistry = new MetricRegistry();
 
   private final MetricRegistryInfo info;
 
diff --git 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RefCountingMap.java 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RefCountingMap.java
index 07112d1..1afaab9 100644
--- 
a/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RefCountingMap.java
+++ 
b/ratis-metrics/src/main/java/org/apache/ratis/metrics/impl/RefCountingMap.java
@@ -34,8 +34,8 @@ class RefCountingMap<K, V> {
 
   private ConcurrentHashMap<K, Payload<V>> map = new ConcurrentHashMap<>();
   private static class Payload<V> {
-    V v;
-    int refCount;
+    private V v;
+    private int refCount;
     Payload(V v) {
       this.v = v;
       this.refCount = 1; // create with ref count = 1