Repository: reef
Updated Branches:
  refs/heads/master 275a08a91 -> 3cafad6b1


[REEF-1034] Change default value of JobSubmissionDirectoryPrefix and add to 
YarnDriverConfiguration

This addressed the issue by
  * Change default value of
  `org.apache.reef.runtime.mesos.driver.parameters.JobSubmissionDirectoryPrefix`
  and 
`org.apache.reef.runtime.yarn.driver.parameters.JobSubmissionDirectoryPrefix`
  from `/vol1/tmp` to `tmp`
  * Add `OptionalParameter` bound to `JobSubmissionDirectoryPrefix` to
  `org.apache.reef.runtime.yarn.client.YarnDriverConfiguration`

JIRA:
  [REEF-1034](https://issues.apache.org/jira/browse/REEF-1034)

Pull Request:
  This closes #744


Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/3cafad6b
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/3cafad6b
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/3cafad6b

Branch: refs/heads/master
Commit: 3cafad6b1b47415fee09f313fd468c38d72bc8c1
Parents: 275a08a
Author: Tobin Baker <[email protected]>
Authored: Tue Dec 15 23:26:42 2015 -0800
Committer: Markus Weimer <[email protected]>
Committed: Tue Dec 22 14:28:39 2015 -0800

----------------------------------------------------------------------
 .../mesos/driver/parameters/JobSubmissionDirectoryPrefix.java | 2 +-
 .../reef/runtime/yarn/client/YarnDriverConfiguration.java     | 7 +++++++
 .../yarn/driver/parameters/JobSubmissionDirectoryPrefix.java  | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/reef/blob/3cafad6b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/parameters/JobSubmissionDirectoryPrefix.java
----------------------------------------------------------------------
diff --git 
a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/parameters/JobSubmissionDirectoryPrefix.java
 
b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/parameters/JobSubmissionDirectoryPrefix.java
index 1ada5a4..815f9d1 100644
--- 
a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/parameters/JobSubmissionDirectoryPrefix.java
+++ 
b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/parameters/JobSubmissionDirectoryPrefix.java
@@ -24,6 +24,6 @@ import org.apache.reef.tang.annotations.NamedParameter;
 /**
  * The job submission directory.
  */
-@NamedParameter(doc = "The job submission directory prefix.", default_value = 
"/vol1/tmp")
+@NamedParameter(doc = "The job submission directory prefix.", default_value = 
"/tmp")
 public final class JobSubmissionDirectoryPrefix implements Name<String> {
 }

http://git-wip-us.apache.org/repos/asf/reef/blob/3cafad6b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnDriverConfiguration.java
----------------------------------------------------------------------
diff --git 
a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnDriverConfiguration.java
 
b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnDriverConfiguration.java
index 9975f36..6cfe2b9 100644
--- 
a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnDriverConfiguration.java
+++ 
b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnDriverConfiguration.java
@@ -20,6 +20,7 @@ package org.apache.reef.runtime.yarn.client;
 
 import org.apache.reef.annotations.audience.ClientSide;
 import org.apache.reef.annotations.audience.Public;
+import 
org.apache.reef.runtime.yarn.driver.parameters.JobSubmissionDirectoryPrefix;
 import org.apache.reef.runtime.yarn.client.parameters.JobQueue;
 import org.apache.reef.tang.formats.ConfigurationModule;
 import org.apache.reef.tang.formats.ConfigurationModuleBuilder;
@@ -36,11 +37,17 @@ public final class YarnDriverConfiguration extends 
ConfigurationModuleBuilder {
    * The queue to submit this Driver to.
    */
   public static final OptionalParameter<String> QUEUE = new 
OptionalParameter<>();
+  
+  /**
+   * The job submission directory.
+   */
+  public static final OptionalParameter<String> 
JOB_SUBMISSION_DIRECTORY_PREFIX = new OptionalParameter<>();
 
   /**
    * ConfigurationModule to set YARN-Specific configuration options to be 
merged with DriverConfiguration.
    */
   public static final ConfigurationModule CONF = new YarnDriverConfiguration()
       .bindNamedParameter(JobQueue.class, QUEUE)
+      .bindNamedParameter(JobSubmissionDirectoryPrefix.class, 
JOB_SUBMISSION_DIRECTORY_PREFIX)
       .build();
 }

http://git-wip-us.apache.org/repos/asf/reef/blob/3cafad6b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/parameters/JobSubmissionDirectoryPrefix.java
----------------------------------------------------------------------
diff --git 
a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/parameters/JobSubmissionDirectoryPrefix.java
 
b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/parameters/JobSubmissionDirectoryPrefix.java
index 30f1741..5a52270 100644
--- 
a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/parameters/JobSubmissionDirectoryPrefix.java
+++ 
b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/parameters/JobSubmissionDirectoryPrefix.java
@@ -24,6 +24,6 @@ import org.apache.reef.tang.annotations.NamedParameter;
 /**
  * The job submission directory.
  */
-@NamedParameter(doc = "The job submission directory prefix.", default_value = 
"/vol1/tmp")
+@NamedParameter(doc = "The job submission directory prefix.", default_value = 
"/tmp")
 public final class JobSubmissionDirectoryPrefix implements Name<String> {
 }

Reply via email to