Repository: reef Updated Branches: refs/heads/master 40a311e49 -> 9ff81875a
[REEF-1112] Update TodoComment checkstyle check This patch: * Adds a new clause to TodoComment check to checkstyle.xml and checkstyle-strict.xml which covers FIX and XXX patterns (equivalent of TODO) * Sets the new clause to the 'warning' level JIRA: [REEF-1112] (https://issues.apache.org/jira/browse/REEF-1112) Pull request: This closes #782 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/9ff81875 Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/9ff81875 Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/9ff81875 Branch: refs/heads/master Commit: 9ff81875a73c08bd5f9674bd866028f994b9cd3b Parents: 40a311e Author: [email protected] <[email protected]> Authored: Wed Jan 20 18:34:30 2016 +0100 Committer: Mariia Mykhailova <[email protected]> Committed: Wed Jan 20 11:42:25 2016 -0800 ---------------------------------------------------------------------- lang/java/reef-common/src/main/resources/checkstyle-strict.xml | 4 ++++ lang/java/reef-common/src/main/resources/checkstyle.xml | 4 ++++ 2 files changed, 8 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/9ff81875/lang/java/reef-common/src/main/resources/checkstyle-strict.xml ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/resources/checkstyle-strict.xml b/lang/java/reef-common/src/main/resources/checkstyle-strict.xml index f55fe27..9278cec 100644 --- a/lang/java/reef-common/src/main/resources/checkstyle-strict.xml +++ b/lang/java/reef-common/src/main/resources/checkstyle-strict.xml @@ -215,6 +215,10 @@ <property name="severity" value="info"/> <property name="format" value="TODO\[JIRA"/> </module> + <module name="TodoComment"> + <property name="severity" value="warning"/> + <property name="format" value="XXX|FIX"/> + </module> <module name="UpperEll"/> <!-- Exception-handling checks. --> http://git-wip-us.apache.org/repos/asf/reef/blob/9ff81875/lang/java/reef-common/src/main/resources/checkstyle.xml ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/resources/checkstyle.xml b/lang/java/reef-common/src/main/resources/checkstyle.xml index 14c6794..4c7b2f2 100644 --- a/lang/java/reef-common/src/main/resources/checkstyle.xml +++ b/lang/java/reef-common/src/main/resources/checkstyle.xml @@ -217,6 +217,10 @@ <property name="severity" value="info"/> <property name="format" value="TODO\[JIRA"/> </module> + <module name="TodoComment"> + <property name="severity" value="warning"/> + <property name="format" value="XXX|FIX"/> + </module> <module name="UpperEll"/> <!-- Exception-handling checks. -->
