Repository: reef
Updated Branches:
  refs/heads/master 436496569 -> d51a427c2


[REEF-1238] Remove obsolete .NET code in O.A.R.Wake and O.A.R.Driver

This change removes obsolete code related to:
 * MaxApplicationSubmissions in YARN job submission parameters
 * Wake Codec creation
 * handler GC in ClrHandlerHelper
 * DefaultEvaluatorRequestorHandler

JIRA:
  [REEF-1238](https://issues.apache.org/jira/browse/REEF-1238)

Pull request:
  This closes #875


Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/d51a427c
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/d51a427c
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/d51a427c

Branch: refs/heads/master
Commit: d51a427c2edf0dfe637417ca9c912143d8e8d3e2
Parents: 4364965
Author: Mariia Mykhailova <[email protected]>
Authored: Thu Mar 3 15:33:53 2016 -0800
Committer: Andrew Chung <[email protected]>
Committed: Tue Mar 8 11:10:28 2016 -0800

----------------------------------------------------------------------
 .../YarnREEFParamSerializerTests.cs             |  2 +-
 .../YARN/YarnREEFParamSerializer.cs             | 10 +---
 .../Bridge/ClrHandlerHelper.cs                  | 11 ----
 .../DefaultEvaluatorRequestorHandler.cs         | 59 --------------------
 .../DriverConfiguration.cs                      |  9 ---
 .../Org.Apache.REEF.Driver.csproj               |  1 -
 .../NetworkServiceConfiguration.cs              | 51 -----------------
 .../Org.Apache.REEF.Network.csproj              |  1 -
 .../Org.Apache.REEF.Wake.csproj                 |  2 -
 lang/cs/Org.Apache.REEF.Wake/Remote/ICodec.cs   |  7 +--
 .../Remote/ICodecFactory.cs                     | 30 ----------
 lang/cs/Org.Apache.REEF.Wake/Remote/IDecoder.cs |  7 +--
 lang/cs/Org.Apache.REEF.Wake/Remote/IEncoder.cs |  7 +--
 .../Remote/Impl/ByteCodecFactory.cs             | 36 ------------
 14 files changed, 7 insertions(+), 226 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Client.Tests/YarnREEFParamSerializerTests.cs
----------------------------------------------------------------------
diff --git 
a/lang/cs/Org.Apache.REEF.Client.Tests/YarnREEFParamSerializerTests.cs 
b/lang/cs/Org.Apache.REEF.Client.Tests/YarnREEFParamSerializerTests.cs
index 16f5533..07ae22f 100644
--- a/lang/cs/Org.Apache.REEF.Client.Tests/YarnREEFParamSerializerTests.cs
+++ b/lang/cs/Org.Apache.REEF.Client.Tests/YarnREEFParamSerializerTests.cs
@@ -175,7 +175,7 @@ namespace Org.Apache.REEF.Client.Tests
                 .SetDriverMemory(AnyInt)
                 .Build();
 
-            var serializedBytes = 
serializer.SerializeJobArgsToBytes(jobRequest.JobParameters, injector, 
AnyString);
+            var serializedBytes = 
serializer.SerializeJobArgsToBytes(jobRequest.JobParameters, AnyString);
             var expectedString = Encoding.UTF8.GetString(serializedBytes);
             var jsonObject = JObject.Parse(expectedString);
             var expectedJsonObject = JObject.Parse(expectedJson);

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Client/YARN/YarnREEFParamSerializer.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Client/YARN/YarnREEFParamSerializer.cs 
b/lang/cs/Org.Apache.REEF.Client/YARN/YarnREEFParamSerializer.cs
index cb207a4..9fcbb63 100644
--- a/lang/cs/Org.Apache.REEF.Client/YARN/YarnREEFParamSerializer.cs
+++ b/lang/cs/Org.Apache.REEF.Client/YARN/YarnREEFParamSerializer.cs
@@ -92,7 +92,7 @@ namespace Org.Apache.REEF.Client.YARN
         /// </summary>
         internal string SerializeJobFile(JobParameters jobParameters, 
IInjector paramInjector, string driverFolderPath)
         {
-            var serializedArgs = SerializeJobArgsToBytes(jobParameters, 
paramInjector, driverFolderPath);
+            var serializedArgs = SerializeJobArgsToBytes(jobParameters, 
driverFolderPath);
 
             var submissionArgsFilePath = Path.Combine(driverFolderPath, 
_fileNames.GetJobSubmissionParametersFile());
             using (var argsFileStream = new FileStream(submissionArgsFilePath, 
FileMode.CreateNew))
@@ -103,7 +103,7 @@ namespace Org.Apache.REEF.Client.YARN
             return submissionArgsFilePath;
         }
 
-        internal byte[] SerializeJobArgsToBytes(JobParameters jobParameters, 
IInjector paramInjector, string driverFolderPath)
+        internal byte[] SerializeJobArgsToBytes(JobParameters jobParameters, 
string driverFolderPath)
         {
             var avroJobSubmissionParameters = new AvroJobSubmissionParameters
             {
@@ -117,17 +117,13 @@ namespace Org.Apache.REEF.Client.YARN
                 sharedJobSubmissionParameters = avroJobSubmissionParameters
             };
 
-            var maxApplicationSubmissions = 
jobParameters.MaxApplicationSubmissions == 1
-                ? 
paramInjector.GetNamedInstance<DriverBridgeConfigurationOptions.MaxApplicationSubmissions,
 int>()
-                : jobParameters.MaxApplicationSubmissions;
-
             var avroYarnClusterJobSubmissionParameters = new 
AvroYarnClusterJobSubmissionParameters
             {
                 securityTokenKind = _securityTokenKind,
                 securityTokenService = _securityTokenService,
                 yarnJobSubmissionParameters = avroYarnJobSubmissionParameters,
                 driverMemory = jobParameters.DriverMemoryInMB,
-                maxApplicationSubmissions = maxApplicationSubmissions
+                maxApplicationSubmissions = 
jobParameters.MaxApplicationSubmissions
             };
 
             return 
AvroJsonSerializer<AvroYarnClusterJobSubmissionParameters>.ToBytes(avroYarnClusterJobSubmissionParameters);

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Driver/Bridge/ClrHandlerHelper.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/ClrHandlerHelper.cs 
b/lang/cs/Org.Apache.REEF.Driver/Bridge/ClrHandlerHelper.cs
index 690b3e6..fb929f4 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/ClrHandlerHelper.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/ClrHandlerHelper.cs
@@ -76,17 +76,6 @@ namespace Org.Apache.REEF.Driver.Bridge
         }
 
         /// <summary>
-        /// Frees a .NET handle.
-        /// </summary>
-        /// <param name="handle">The handle to free</param>
-        [Obsolete("Deprecated in 0.14. Will be removed in 0.15.")]
-        public static void FreeHandle(ulong handle)
-        {
-            GCHandle gc = GCHandle.FromIntPtr((IntPtr)handle);
-            gc.Free();
-        }
-
-        /// <summary>
         /// Returns the null handle not used on the Java side (i.e. 0).
         /// </summary>
         /// <returns>The null handle</returns>

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Driver/Defaults/DefaultEvaluatorRequestorHandler.cs
----------------------------------------------------------------------
diff --git 
a/lang/cs/Org.Apache.REEF.Driver/Defaults/DefaultEvaluatorRequestorHandler.cs 
b/lang/cs/Org.Apache.REEF.Driver/Defaults/DefaultEvaluatorRequestorHandler.cs
deleted file mode 100644
index 51a754b..0000000
--- 
a/lang/cs/Org.Apache.REEF.Driver/Defaults/DefaultEvaluatorRequestorHandler.cs
+++ /dev/null
@@ -1,59 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-using System;
-using Org.Apache.REEF.Driver.Evaluator;
-using Org.Apache.REEF.Tang.Annotations;
-using Org.Apache.REEF.Utilities.Logging;
-
-namespace Org.Apache.REEF.Driver.Defaults
-{
-    /// <summary>
-    /// Default handler for close messages from the client: logging it
-    /// </summary>
-    [Obsolete("In Version 0.13. Have an instance of IEvaluatorRequestor 
injected instead.")]
-    public class DefaultEvaluatorRequestorHandler : 
IObserver<IEvaluatorRequestor>
-    {
-        private static readonly Logger LOGGER = 
Logger.GetLogger(typeof(DefaultClientCloseHandler));
-
-        [Inject]
-        public DefaultEvaluatorRequestorHandler()
-        {
-        }
-
-        public void OnNext(IEvaluatorRequestor value)
-        {
-            LOGGER.Log(Level.Info, "Default evaluator requestor: requesting 1 
evaluator with 512 MB");
-            int evaluatorsNumber = 1;
-            int memory = 512;
-            string rack = "WonderlandRack";
-            EvaluatorRequest request = new EvaluatorRequest(evaluatorsNumber, 
memory, rack);
-
-            value.Submit(request);
-        }
-
-        public void OnError(Exception error)
-        {
-            throw new NotImplementedException();
-        }
-
-        public void OnCompleted()
-        {
-            throw new NotImplementedException();
-        }
-    }
-}
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Driver/DriverConfiguration.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/DriverConfiguration.cs 
b/lang/cs/Org.Apache.REEF.Driver/DriverConfiguration.cs
index 8242721..1827cbf 100644
--- a/lang/cs/Org.Apache.REEF.Driver/DriverConfiguration.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/DriverConfiguration.cs
@@ -169,13 +169,6 @@ namespace Org.Apache.REEF.Driver
             new OptionalParameter<TraceListener>();
 
         /// <summary>
-        /// The number of times the application should be submitted in case of 
failures
-        /// </summary>
-        [Obsolete("Deprecated in 0.14, will be removed.")]
-        public static readonly OptionalParameter<int> 
MaxApplicationSubmissions =
-            new OptionalParameter<int>();
-
-        /// <summary>
         /// The implemenation for (attempting to) re-establish connection to 
driver
         /// </summary>
         public static readonly OptionalImpl<IDriverConnection> 
OnDriverReconnect = new OptionalImpl<IDriverConnection>();
@@ -235,8 +228,6 @@ namespace Org.Apache.REEF.Driver
                     
.BindSetEntry(GenericType<DriverBridgeConfigurationOptions.DriverRestartFailedEvaluatorHandlers>.Class,
                         OnDriverRestartEvaluatorFailed)
                     
.BindNamedParameter(GenericType<DriverBridgeConfigurationOptions.TraceLevel>.Class,
 CustomTraceLevel)
-                    
.BindNamedParameter(GenericType<DriverBridgeConfigurationOptions.MaxApplicationSubmissions>.Class,
-                        MaxApplicationSubmissions)
                     
.BindNamedParameter(GenericType<DriverBridgeConfigurationOptions.DriverRestartEvaluatorRecoverySeconds>.Class,
                         DriverRestartEvaluatorRecoverySeconds)
                     .BindImplementation(GenericType<IProgressProvider>.Class, 
ProgressProvider)

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Driver/Org.Apache.REEF.Driver.csproj
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Org.Apache.REEF.Driver.csproj 
b/lang/cs/Org.Apache.REEF.Driver/Org.Apache.REEF.Driver.csproj
index 3deef72..d6c845a 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Org.Apache.REEF.Driver.csproj
+++ b/lang/cs/Org.Apache.REEF.Driver/Org.Apache.REEF.Driver.csproj
@@ -115,7 +115,6 @@ under the License.
     <Compile Include="Defaults\DefaultEvaluatorAllocationHandler.cs" />
     <Compile Include="Defaults\DefaultEvaluatorCompletionHandler.cs" />
     <Compile Include="Defaults\DefaultEvaluatorFailureHandler.cs" />
-    <Compile Include="Defaults\DefaultEvaluatorRequestorHandler.cs" />
     <Compile Include="Defaults\DefaultHttpHandler.cs" />
     <Compile Include="Defaults\DefaultTaskCompletionHandler.cs" />
     <Compile Include="Defaults\DefaultTaskFailureHandler.cs" />

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Network/NetworkService/NetworkServiceConfiguration.cs
----------------------------------------------------------------------
diff --git 
a/lang/cs/Org.Apache.REEF.Network/NetworkService/NetworkServiceConfiguration.cs 
b/lang/cs/Org.Apache.REEF.Network/NetworkService/NetworkServiceConfiguration.cs
deleted file mode 100644
index a5407ba..0000000
--- 
a/lang/cs/Org.Apache.REEF.Network/NetworkService/NetworkServiceConfiguration.cs
+++ /dev/null
@@ -1,51 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-using System;
-using System.Diagnostics.CodeAnalysis;
-using Org.Apache.REEF.Common.Io;
-using Org.Apache.REEF.Tang.Formats;
-using Org.Apache.REEF.Tang.Util;
-using Org.Apache.REEF.Wake.Remote;
-
-namespace Org.Apache.REEF.Network.NetworkService
-{
-    [Obsolete("Deprecated in 0.14.")]
-    public class NetworkServiceConfiguration : ConfigurationModuleBuilder
-    {
-        [SuppressMessage("Microsoft.Security", "CA2104:Do not declare read 
only mutable reference types", Justification = "not applicable")] 
-        public static readonly RequiredParameter<int> NetworkServicePort = new 
RequiredParameter<int>();
-
-        [SuppressMessage("Microsoft.Security", "CA2104:Do not declare read 
only mutable reference types", Justification = "not applicable")] 
-        public static readonly RequiredImpl<ICodecFactory> 
NetworkServiceCodecFactory = new RequiredImpl<ICodecFactory>();
-
-        public static ConfigurationModule ConfigurationModule
-        {
-            get
-            {
-                return new NetworkServiceConfiguration()
-                    
.BindNamedParameter(GenericType<NetworkServiceOptions.NetworkServicePort>.Class,
 NetworkServicePort)
-                    
.BindNamedParameter(GenericType<NamingConfigurationOptions.NameServerPort>.Class,
-                                        NamingConfiguration.NameServerPort)
-                    
.BindNamedParameter(GenericType<NamingConfigurationOptions.NameServerAddress>.Class,
-                                        NamingConfiguration.NameServerAddress)
-                    .BindImplementation(GenericType<ICodecFactory>.Class, 
NetworkServiceCodecFactory)
-                    .Build();
-            }
-        }
-    }
-}

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Network/Org.Apache.REEF.Network.csproj
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Network/Org.Apache.REEF.Network.csproj 
b/lang/cs/Org.Apache.REEF.Network/Org.Apache.REEF.Network.csproj
index 4c28bf8..8e16ae0 100644
--- a/lang/cs/Org.Apache.REEF.Network/Org.Apache.REEF.Network.csproj
+++ b/lang/cs/Org.Apache.REEF.Network/Org.Apache.REEF.Network.csproj
@@ -150,7 +150,6 @@ under the License.
     <Compile Include="NetworkService\IConnection.cs" />
     <Compile Include="NetworkService\INetworkService.cs" />
     <Compile Include="NetworkService\NetworkService.cs" />
-    <Compile Include="NetworkService\NetworkServiceConfiguration.cs" />
     <Compile Include="NetworkService\NetworkServiceOptions.cs" />
     <Compile Include="NetworkService\NsConnection.cs" />
     <Compile Include="NetworkService\NsMessage.cs" />

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Wake/Org.Apache.REEF.Wake.csproj
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Org.Apache.REEF.Wake.csproj 
b/lang/cs/Org.Apache.REEF.Wake/Org.Apache.REEF.Wake.csproj
index 2475079..391648e 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Org.Apache.REEF.Wake.csproj
+++ b/lang/cs/Org.Apache.REEF.Wake/Org.Apache.REEF.Wake.csproj
@@ -80,12 +80,10 @@ under the License.
       <ExcludeFromStyleCop>true</ExcludeFromStyleCop>
     </Compile>
     <Compile Include="Remote\ICodec.cs" />
-    <Compile Include="Remote\ICodecFactory.cs" />
     <Compile Include="Remote\IDecoder.cs" />
     <Compile Include="Remote\IEncoder.cs" />
     <Compile Include="Remote\ILink.cs" />
     <Compile Include="Remote\Impl\ByteCodec.cs" />
-    <Compile Include="Remote\Impl\ByteCodecFactory.cs" />
     <Compile Include="Remote\Impl\Channel.cs" />
     <Compile Include="Remote\Impl\DefaultRemoteManager.cs" />
     <Compile Include="Remote\Impl\DefaultRemoteMessage.cs" />

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Wake/Remote/ICodec.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Remote/ICodec.cs 
b/lang/cs/Org.Apache.REEF.Wake/Remote/ICodec.cs
index 3ef9e54..14e8ddb 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Remote/ICodec.cs
+++ b/lang/cs/Org.Apache.REEF.Wake/Remote/ICodec.cs
@@ -19,17 +19,12 @@ using System;
 
 namespace Org.Apache.REEF.Wake.Remote
 {
-    [Obsolete("Deprecated in 0.14, please use ICodec<T> instead.")]
-    public interface ICodec
-    {
-    }
-
     /// <summary>
     /// Interface for serialization routines that translate back and forth 
between
     /// byte arrays with low latency.
     /// </summary>
     /// <typeparam name="T">The codec type</typeparam>
-    public interface ICodec<T> : ICodec, IEncoder<T>, IDecoder<T>
+    public interface ICodec<T> : IEncoder<T>, IDecoder<T>
     {
     }
 }

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Wake/Remote/ICodecFactory.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Remote/ICodecFactory.cs 
b/lang/cs/Org.Apache.REEF.Wake/Remote/ICodecFactory.cs
deleted file mode 100644
index 6538f05..0000000
--- a/lang/cs/Org.Apache.REEF.Wake/Remote/ICodecFactory.cs
+++ /dev/null
@@ -1,30 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-using System;
-using Org.Apache.REEF.Tang.Annotations;
-using Org.Apache.REEF.Wake.Remote.Impl;
-
-namespace Org.Apache.REEF.Wake.Remote
-{
-    [Obsolete("Deprecated in 0.14, please inject the ICodec directly or use 
its constructor instead.")]
-    [DefaultImplementation(typeof(ByteCodecFactory))]
-    public interface ICodecFactory
-    {
-        object Create(); 
-    }
-}

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Wake/Remote/IDecoder.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Remote/IDecoder.cs 
b/lang/cs/Org.Apache.REEF.Wake/Remote/IDecoder.cs
index 812469b..ac5bf87 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Remote/IDecoder.cs
+++ b/lang/cs/Org.Apache.REEF.Wake/Remote/IDecoder.cs
@@ -19,17 +19,12 @@ using System;
 
 namespace Org.Apache.REEF.Wake.Remote
 {
-    [Obsolete("Deprecated in 0.14, please use ICodec<T> instead.")]
-    public interface IDecoder
-    {
-    }
-
     /// <summary>
     /// Interface for serialization routines that translate back and forth 
between
     /// byte arrays with low latency.
     /// </summary>
     /// <typeparam name="T">The decoder type</typeparam>
-    public interface IDecoder<T> : IDecoder
+    public interface IDecoder<T> 
     {
         /// <summary>Decodes the given byte array into an object</summary>
         /// <param name="data"></param>

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Wake/Remote/IEncoder.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Remote/IEncoder.cs 
b/lang/cs/Org.Apache.REEF.Wake/Remote/IEncoder.cs
index 92daea7..49638f4 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Remote/IEncoder.cs
+++ b/lang/cs/Org.Apache.REEF.Wake/Remote/IEncoder.cs
@@ -19,17 +19,12 @@ using System;
 
 namespace Org.Apache.REEF.Wake.Remote
 {
-    [Obsolete("Deprecated in 0.14, please use IEncoder<T> instead.")]
-    public interface IEncoder
-    {
-    }
-
     /// <summary>
     /// Interface for serialization routines that translate back and forth 
between
     /// byte arrays with low latency.
     /// </summary>
     /// <typeparam name="T">The encoder type</typeparam>
-    public interface IEncoder<T> : IEncoder
+    public interface IEncoder<T>
     {
         /// <summary>Encodes the given object into a Byte Array</summary>
         /// <param name="obj"></param>

http://git-wip-us.apache.org/repos/asf/reef/blob/d51a427c/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/ByteCodecFactory.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/ByteCodecFactory.cs 
b/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/ByteCodecFactory.cs
deleted file mode 100644
index a57f341..0000000
--- a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/ByteCodecFactory.cs
+++ /dev/null
@@ -1,36 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-using System;
-using Org.Apache.REEF.Tang.Annotations;
-
-namespace Org.Apache.REEF.Wake.Remote.Impl
-{
-    [Obsolete("Deprecated in 0.14, please inject or call ByteCodec's 
constructor instead.")]
-    public sealed class ByteCodecFactory : ICodecFactory
-    {
-        [Inject]
-        public ByteCodecFactory()
-        {
-        }
-
-        public object Create()
-        {
-            return new ByteCodec();
-        }
-    }
-}

Reply via email to