Repository: reef Updated Branches: refs/heads/master 73bfc0a63 -> f3000d817
[REEF-904] Act on deprecated JobSubmissionDirectory This removes the deprecated `org.apache.reef.driver.parameters.JobSubmissionDirectory`. JIRA: [REEF-904](https://issues.apache.org/jira/browse/REEF-904) Pull Request: This closes #906 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/f3000d81 Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/f3000d81 Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/f3000d81 Branch: refs/heads/master Commit: f3000d817a05b00ea1799cdd76fec829a57f228f Parents: 73bfc0a Author: Dongjoon Hyun <[email protected]> Authored: Sat Mar 26 00:01:31 2016 -0700 Committer: Markus Weimer <[email protected]> Committed: Mon Mar 28 10:57:40 2016 -0700 ---------------------------------------------------------------------- .../parameters/JobSubmissionDirectory.java | 31 -------------------- .../client/HDInsightDriverConfiguration.java | 2 -- .../yarn/driver/YarnDriverConfiguration.java | 2 -- 3 files changed, 35 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/f3000d81/lang/java/reef-common/src/main/java/org/apache/reef/driver/parameters/JobSubmissionDirectory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/parameters/JobSubmissionDirectory.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/parameters/JobSubmissionDirectory.java deleted file mode 100644 index 344bafa..0000000 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/parameters/JobSubmissionDirectory.java +++ /dev/null @@ -1,31 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -package org.apache.reef.driver.parameters; - -import org.apache.reef.tang.annotations.NamedParameter; -import org.apache.reef.tang.annotations.Name; - -/** - * @deprecated in 0.14. Use org.apache.reef.runtime.yarn.driver.parameters.JobSubmissionDirectory. - */ -// TODO[JIRA REEF-904]: Act on deprecated JobSubmissionDirectory and JOB_SUBMISSION_DIRECTORY -@NamedParameter(doc = "The job submission directory.") -public final class JobSubmissionDirectory implements Name<String> { -} http://git-wip-us.apache.org/repos/asf/reef/blob/f3000d81/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightDriverConfiguration.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightDriverConfiguration.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightDriverConfiguration.java index 133d33e..d3b10b1 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightDriverConfiguration.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightDriverConfiguration.java @@ -92,8 +92,6 @@ public final class HDInsightDriverConfiguration extends ConfigurationModuleBuild .bindImplementation(TempFileCreator.class, WorkingDirectoryTempFileCreator.class) // Bind the YARN Configuration parameters - // TODO[JIRA REEF-904]: Act on deprecated JobSubmissionDirectory and JOB_SUBMISSION_DIRECTORY - .bindNamedParameter(org.apache.reef.driver.parameters.JobSubmissionDirectory.class, JOB_SUBMISSION_DIRECTORY) .bindNamedParameter(JobSubmissionDirectory.class, JOB_SUBMISSION_DIRECTORY) .bindNamedParameter(YarnHeartbeatPeriod.class, YARN_HEARTBEAT_INTERVAL) http://git-wip-us.apache.org/repos/asf/reef/blob/f3000d81/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnDriverConfiguration.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnDriverConfiguration.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnDriverConfiguration.java index 33ffccc..178ca16 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnDriverConfiguration.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnDriverConfiguration.java @@ -86,8 +86,6 @@ public class YarnDriverConfiguration extends ConfigurationModuleBuilder { .bindImplementation(TempFileCreator.class, WorkingDirectoryTempFileCreator.class) // Bind the YARN Configuration parameters - // TODO[JIRA REEF-904]: Act on deprecated JobSubmissionDirectory and JOB_SUBMISSION_DIRECTORY - .bindNamedParameter(org.apache.reef.driver.parameters.JobSubmissionDirectory.class, JOB_SUBMISSION_DIRECTORY) .bindNamedParameter(JobSubmissionDirectory.class, JOB_SUBMISSION_DIRECTORY) .bindNamedParameter(YarnHeartbeatPeriod.class, YARN_HEARTBEAT_INTERVAL)
