Repository: reef Updated Branches: refs/heads/master 414d4b451 -> dbd628a31
[REEF-1414] Condition to EvaluatorExitLogger is inverted for RuntimeStop This addressed the issue by * Using successfulExit instead of exceptionOccurredOnDispose for better code clarity. JIRA: [REEF-1414](https://issues.apache.org/jira/browse/REEF-1414) Pull Request: This closes #1022 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/dbd628a3 Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/dbd628a3 Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/dbd628a3 Branch: refs/heads/master Commit: dbd628a310ee1c4f28ec1d392896c6e58b10215f Parents: 414d4b4 Author: Andrew Chung <[email protected]> Authored: Thu Jun 2 14:50:00 2016 -0700 Committer: Markus Weimer <[email protected]> Committed: Thu Jun 2 16:03:09 2016 -0700 ---------------------------------------------------------------------- .../Runtime/Evaluator/EvaluatorRuntime.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/dbd628a3/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/EvaluatorRuntime.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/EvaluatorRuntime.cs b/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/EvaluatorRuntime.cs index b8e3437..973ea3c 100644 --- a/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/EvaluatorRuntime.cs +++ b/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/EvaluatorRuntime.cs @@ -211,7 +211,7 @@ namespace Org.Apache.REEF.Common.Runtime.Evaluator } else { - var exceptionOccurredOnDispose = false; + var successfulExit = true; try { _contextManager.Dispose(); @@ -219,7 +219,7 @@ namespace Org.Apache.REEF.Common.Runtime.Evaluator } catch (Exception e) { - exceptionOccurredOnDispose = true; + successfulExit = false; Utilities.Diagnostics.Exceptions.CaughtAndThrow( new InvalidOperationException("Cannot stop evaluator properly", e), Level.Error, @@ -228,7 +228,7 @@ namespace Org.Apache.REEF.Common.Runtime.Evaluator } finally { - _evaluatorExitLogger.LogExit(exceptionOccurredOnDispose); + _evaluatorExitLogger.LogExit(successfulExit); } } }
