Repository: reef Updated Branches: refs/heads/master 5ed617298 -> 9640716f0
[REEF-1440] Test tasks should not throw NotImplementedException in Dispose This change removes throwing NotImplementedException in Dispose methods of tasks used in .NET tests. JIRA: [REEF-1440](https://issues.apache.org/jira/browse/REEF-1440) Pull request: This closes #1034 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/9640716f Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/9640716f Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/9640716f Branch: refs/heads/master Commit: 9640716f07efeaf905f71a20455fb324ddba6f2e Parents: 5ed6172 Author: Mariia Mykhailova <[email protected]> Authored: Tue Jun 7 11:04:24 2016 -0700 Committer: Andrew Chung <[email protected]> Committed: Tue Jun 7 11:16:20 2016 -0700 ---------------------------------------------------------------------- .../GroupCommunication/GroupCommunicationTests.cs | 1 - .../Functional/Bridge/TestFailedEvaluatorEventHandler.cs | 3 --- .../Functional/Bridge/TestUnhandledTaskException.cs | 1 - .../Functional/FaultTolerant/TestResubmitEvaluator.cs | 1 - 4 files changed, 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/9640716f/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs b/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs index 175ce05..5eefd44 100644 --- a/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs +++ b/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs @@ -957,7 +957,6 @@ namespace Org.Apache.REEF.Network.Tests.GroupCommunication { public void Dispose() { - throw new NotImplementedException(); } public byte[] Call(byte[] memento) http://git-wip-us.apache.org/repos/asf/reef/blob/9640716f/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestFailedEvaluatorEventHandler.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestFailedEvaluatorEventHandler.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestFailedEvaluatorEventHandler.cs index 123bdc6..8d75518 100644 --- a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestFailedEvaluatorEventHandler.cs +++ b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestFailedEvaluatorEventHandler.cs @@ -22,11 +22,9 @@ using System.Threading; using Org.Apache.REEF.Common.Tasks; using Org.Apache.REEF.Common.Tasks.Events; using Org.Apache.REEF.Driver; -using Org.Apache.REEF.Driver.Bridge; using Org.Apache.REEF.Driver.Evaluator; using Org.Apache.REEF.Driver.Task; using Org.Apache.REEF.Tang.Annotations; -using Org.Apache.REEF.Tang.Implementations.Tang; using Org.Apache.REEF.Tang.Interface; using Org.Apache.REEF.Tang.Util; using Org.Apache.REEF.Utilities.Logging; @@ -138,7 +136,6 @@ namespace Org.Apache.REEF.Tests.Functional.Bridge public void Dispose() { - throw new NotImplementedException(); } public byte[] Call(byte[] memento) http://git-wip-us.apache.org/repos/asf/reef/blob/9640716f/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestUnhandledTaskException.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestUnhandledTaskException.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestUnhandledTaskException.cs index fda2c0c..238a143 100644 --- a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestUnhandledTaskException.cs +++ b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestUnhandledTaskException.cs @@ -103,7 +103,6 @@ namespace Org.Apache.REEF.Tests.Functional.Bridge public void Dispose() { - throw new NotImplementedException(); } } http://git-wip-us.apache.org/repos/asf/reef/blob/9640716f/lang/cs/Org.Apache.REEF.Tests/Functional/FaultTolerant/TestResubmitEvaluator.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/FaultTolerant/TestResubmitEvaluator.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/FaultTolerant/TestResubmitEvaluator.cs index 9a50d75..d0bddde 100644 --- a/lang/cs/Org.Apache.REEF.Tests/Functional/FaultTolerant/TestResubmitEvaluator.cs +++ b/lang/cs/Org.Apache.REEF.Tests/Functional/FaultTolerant/TestResubmitEvaluator.cs @@ -248,7 +248,6 @@ namespace Org.Apache.REEF.Tests.Functional.FaultTolerant public void Dispose() { - throw new NotImplementedException(); } public void OnCompleted()
