Repository: reef Updated Branches: refs/heads/master e227f8d7e -> 9fd95d046
[REEF-1572] Clean up class hierarchy for Map/UpdateTaskHost This change moves inheritance from ITask and IObserver<ICloseEvent> from Map/UpdateTaskHost to TaskHostBase. JIRA: [REEF-1572](https://issues.apache.org/jira/browse/REEF-1572) Pull request: This closes #1129 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/9fd95d04 Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/9fd95d04 Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/9fd95d04 Branch: refs/heads/master Commit: 9fd95d04682c58e9ae8868ba8bed80a28b00511c Parents: e227f8d Author: Mariia Mykhailova <[email protected]> Authored: Thu Sep 22 17:26:53 2016 -0700 Committer: Markus Weimer <[email protected]> Committed: Fri Sep 23 11:04:49 2016 -0700 ---------------------------------------------------------------------- lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/MapTaskHost.cs | 3 +-- lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/TaskHostBase.cs | 3 ++- lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/UpdateTaskHost.cs | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/9fd95d04/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/MapTaskHost.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/MapTaskHost.cs b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/MapTaskHost.cs index f843036..7afa955 100644 --- a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/MapTaskHost.cs +++ b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/MapTaskHost.cs @@ -17,7 +17,6 @@ using System; using Org.Apache.REEF.Common.Tasks; -using Org.Apache.REEF.Common.Tasks.Events; using Org.Apache.REEF.IMRU.API; using Org.Apache.REEF.IMRU.OnREEF.Driver; using Org.Apache.REEF.IMRU.OnREEF.MapInputWithControlMessage; @@ -36,7 +35,7 @@ namespace Org.Apache.REEF.IMRU.OnREEF.IMRUTasks /// <typeparam name="TMapInput">Map input</typeparam> /// <typeparam name="TMapOutput">Map output</typeparam> [ThreadSafe] - internal sealed class MapTaskHost<TMapInput, TMapOutput> : TaskHostBase, ITask, IObserver<ICloseEvent> + internal sealed class MapTaskHost<TMapInput, TMapOutput> : TaskHostBase { private static readonly Logger Logger = Logger.GetLogger(typeof(MapTaskHost<TMapInput, TMapOutput>)); http://git-wip-us.apache.org/repos/asf/reef/blob/9fd95d04/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/TaskHostBase.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/TaskHostBase.cs b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/TaskHostBase.cs index c14ff73..3c26d90 100644 --- a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/TaskHostBase.cs +++ b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/TaskHostBase.cs @@ -20,6 +20,7 @@ using System.IO; using System.Net.Sockets; using System.Runtime.Remoting; using System.Threading; +using Org.Apache.REEF.Common.Tasks; using Org.Apache.REEF.Common.Tasks.Events; using Org.Apache.REEF.IMRU.OnREEF.Driver; using Org.Apache.REEF.Network.Group.Task; @@ -28,7 +29,7 @@ using Org.Apache.REEF.Wake.Remote.Impl; namespace Org.Apache.REEF.IMRU.OnREEF.IMRUTasks { - internal abstract class TaskHostBase + internal abstract class TaskHostBase : ITask, IObserver<ICloseEvent> { private static readonly Logger Logger = Logger.GetLogger(typeof(TaskHostBase)); http://git-wip-us.apache.org/repos/asf/reef/blob/9fd95d04/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/UpdateTaskHost.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/UpdateTaskHost.cs b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/UpdateTaskHost.cs index 382721c..60694e5 100644 --- a/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/UpdateTaskHost.cs +++ b/lang/cs/Org.Apache.REEF.IMRU/OnREEF/IMRUTasks/UpdateTaskHost.cs @@ -17,7 +17,6 @@ using System; using Org.Apache.REEF.Common.Tasks; -using Org.Apache.REEF.Common.Tasks.Events; using Org.Apache.REEF.IMRU.API; using Org.Apache.REEF.IMRU.OnREEF.Driver; using Org.Apache.REEF.IMRU.OnREEF.MapInputWithControlMessage; @@ -37,7 +36,7 @@ namespace Org.Apache.REEF.IMRU.OnREEF.IMRUTasks /// <typeparam name="TMapOutput">Map output</typeparam> /// <typeparam name="TResult">Final result</typeparam> [ThreadSafe] - internal sealed class UpdateTaskHost<TMapInput, TMapOutput, TResult> : TaskHostBase, ITask, IObserver<ICloseEvent> + internal sealed class UpdateTaskHost<TMapInput, TMapOutput, TResult> : TaskHostBase { private static readonly Logger Logger = Logger.GetLogger(typeof(UpdateTaskHost<TMapInput, TMapOutput, TResult>));
