Repository: reef Updated Branches: refs/heads/master 4550b841d -> 2fd16b5fc
[REEF-1376] Delete empty setter in Common.Tasks.TaskMessage.Message (breaking) JIRA: [REEF-1376](https://issues.apache.org/jira/browse/REEF-1376) Pull request: This closes #1246 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/2fd16b5f Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/2fd16b5f Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/2fd16b5f Branch: refs/heads/master Commit: 2fd16b5fce2e19c611ce22a79409af353e90763e Parents: 4550b84 Author: Mariia Mykhailova <[email protected]> Authored: Mon Jan 30 09:45:09 2017 -0800 Committer: Markus Weimer <[email protected]> Committed: Mon Jan 30 13:50:26 2017 -0800 ---------------------------------------------------------------------- .../Org.Apache.REEF.Common/Tasks/TaskMessage.cs | 20 ++++++++++---------- .../Bridge/Events/TaskMessage.cs | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/2fd16b5f/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs b/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs index 4e1a5a0..0e1d8b2 100644 --- a/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs +++ b/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs @@ -17,48 +17,48 @@ using System; using Org.Apache.REEF.Utilities; -using Org.Apache.REEF.Utilities.Logging; namespace Org.Apache.REEF.Common.Tasks { + /// <summary> + /// Task-side TaskMessage. + /// </summary> public class TaskMessage : IMessage { - private static readonly Logger LOGGER = Logger.GetLogger(typeof(TaskMessage)); - private readonly string _messageSourcId; + private readonly string _messageSourceId; private readonly byte[] _bytes; private TaskMessage(string messageSourceId, byte[] bytes) { - _messageSourcId = messageSourceId; + _messageSourceId = messageSourceId; _bytes = bytes; } public string MessageSourceId { - get { return _messageSourcId; } + get { return _messageSourceId; } } public byte[] Message { get { return _bytes; } - set { } } /// <summary> - /// From byte[] message to a TaskMessage + /// From byte[] message to a TaskMessage /// </summary> - /// <param name="messageSourceId">messageSourceId The message's sourceID. This will be accessible in the Driver for routing</param> + /// <param name="messageSourceId">The message's sourceID. This will be accessible in the Driver for routing</param> /// <param name="message">The actual content of the message, serialized into a byte[]</param> /// <returns>a new TaskMessage with the given content</returns> public static TaskMessage From(string messageSourceId, byte[] message) { if (string.IsNullOrEmpty(messageSourceId)) { - Org.Apache.REEF.Utilities.Diagnostics.Exceptions.Throw(new ArgumentNullException("messageSourceId"), LOGGER); + throw new ArgumentNullException("messageSourceId"); } if (message == null) { - Org.Apache.REEF.Utilities.Diagnostics.Exceptions.Throw(new ArgumentNullException("bytes"), LOGGER); + throw new ArgumentNullException("message"); } return new TaskMessage(messageSourceId, message); } http://git-wip-us.apache.org/repos/asf/reef/blob/2fd16b5f/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs index ea4c1e9..70de035 100644 --- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs +++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs @@ -22,7 +22,7 @@ using Org.Apache.REEF.Driver.Task; namespace Org.Apache.REEF.Driver.Bridge.Events { /// <summary> - /// TaskMessage which wraps ITaskMessageClr2Java + /// Driver-side TaskMessage which wraps ITaskMessageClr2Java /// </summary> [DataContract] internal sealed class TaskMessage : ITaskMessage
