Repository: reef
Updated Branches:
refs/heads/master 0d7094717 -> 1312c8db5
[REEF-1584] Fix CoreCLR Issues in Org.Apache.REEF.IO
This addressed the issue by
* Targeting .NET Core 2.0 Framework
* Rewriting the DirectoryInfo.Create(DirectorySecurity) and
CreateSubdirectory(DirectorySecurity) commands to use the SetAccessControl APIs
that are supported in .NET Core 2.0
* See the Extension Methods section of the [.NET Standard 2.0
documentation](https://docs.microsoft.com/en-us/dotnet/api/system.io.directoryinfo?view=netstandard-2.0)
for details on the supported APIs. (Note that these extensions are all .NET
Core 2.0, not .NET Standard.)
JIRA:
[REEF-1584](https://issues.apache.org/jira/browse/REEF-1584)
Pull request:
This closes #1351
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/1312c8db
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/1312c8db
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/1312c8db
Branch: refs/heads/master
Commit: 1312c8db589d2499401a65a9c9e9480fb659fab1
Parents: 0d70947
Author: roganc <[email protected]>
Authored: Wed Aug 2 17:36:25 2017 -0700
Committer: Doug Service <[email protected]>
Committed: Mon Aug 7 21:49:01 2017 +0000
----------------------------------------------------------------------
lang/cs/Org.Apache.REEF.IO/Files/DefaultDirectoryInfo.cs | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/1312c8db/lang/cs/Org.Apache.REEF.IO/Files/DefaultDirectoryInfo.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IO/Files/DefaultDirectoryInfo.cs
b/lang/cs/Org.Apache.REEF.IO/Files/DefaultDirectoryInfo.cs
index 47a86fe..29011a8 100644
--- a/lang/cs/Org.Apache.REEF.IO/Files/DefaultDirectoryInfo.cs
+++ b/lang/cs/Org.Apache.REEF.IO/Files/DefaultDirectoryInfo.cs
@@ -180,7 +180,8 @@ namespace Org.Apache.REEF.IO.Files
/// </summary>
public void Create(DirectorySecurity directorySecurity)
{
- _directoryInfo.Create(directorySecurity);
+ _directoryInfo.Create();
+ _directoryInfo.SetAccessControl(directorySecurity);
}
/// <summary>
@@ -196,7 +197,9 @@ namespace Org.Apache.REEF.IO.Files
/// </summary>
public IDirectoryInfo CreateSubdirectory(string path,
DirectorySecurity directorySecurity)
{
- return FromDirectoryInfo(_directoryInfo.CreateSubdirectory(path,
directorySecurity));
+ var directoryInfo = CreateSubdirectory(path);
+ directoryInfo.SetAccessControl(directorySecurity);
+ return directoryInfo;
}
/// <summary>
