Repository: reef Updated Branches: refs/heads/master a431a8c3f -> b6c9a93c4
[REEF-1904] add toString() to LocalAddressProvider implementations We need this to improve log readability in the remote manager JIRA: [REEF-1904](https://issues.apache.org/jira/browse/REEF-1904) Pull Request: This closes #1393 Project: http://git-wip-us.apache.org/repos/asf/reef/repo Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/b6c9a93c Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/b6c9a93c Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/b6c9a93c Branch: refs/heads/master Commit: b6c9a93c4496f9bdbe2ce7dde6fb89d60bae82d3 Parents: a431a8c Author: Sergiy Matusevych <[email protected]> Authored: Wed Oct 18 16:31:24 2017 -0700 Committer: Doug Service <[email protected]> Committed: Mon Oct 23 21:06:41 2017 +0000 ---------------------------------------------------------------------- .../remote/address/HostnameBasedLocalAddressProvider.java | 7 +++++++ .../wake/remote/address/LoopbackLocalAddressProvider.java | 9 ++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/reef/blob/b6c9a93c/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java index c8b484c..4f0d442 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java @@ -31,7 +31,9 @@ import java.util.logging.Logger; * A LocalAddressProvider that uses <code>Inet4Address.getLocalHost().getHostAddress()</code>. */ public final class HostnameBasedLocalAddressProvider implements LocalAddressProvider { + private static final Logger LOG = Logger.getLogger(HostnameBasedLocalAddressProvider.class.getName()); + private String cached = null; /** @@ -63,4 +65,9 @@ public final class HostnameBasedLocalAddressProvider implements LocalAddressProv .bind(LocalAddressProvider.class, HostnameBasedLocalAddressProvider.class) .build(); } + + @Override + public String toString() { + return "HostnameBasedLocalAddressProvider:" + this.getLocalAddress(); + } } http://git-wip-us.apache.org/repos/asf/reef/blob/b6c9a93c/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java index 9baff92..5f7dcfc 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java @@ -31,6 +31,8 @@ import java.net.InetAddress; */ public final class LoopbackLocalAddressProvider implements LocalAddressProvider { + private final String address = InetAddress.getLoopbackAddress().getHostAddress(); + @Inject private LoopbackLocalAddressProvider() { } @@ -38,7 +40,7 @@ public final class LoopbackLocalAddressProvider implements LocalAddressProvider @Override public String getLocalAddress() { // Use the loopback address. - return InetAddress.getLoopbackAddress().getHostAddress(); + return this.address; } @Override @@ -48,4 +50,9 @@ public final class LoopbackLocalAddressProvider implements LocalAddressProvider .bindNamedParameter(RemoteConfiguration.HostAddress.class, getLocalAddress()) .build(); } + + @Override + public String toString() { + return "LoopbackLocalAddressProvider:" + address; + } }
