Repository: incubator-reef Updated Branches: refs/heads/master 9964d5db3 -> 660ee805d
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java index 11348b9..3f1977f 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java @@ -35,18 +35,18 @@ public interface Tang { * * @throws BindException If the confs conflict, a BindException will be thrown. */ - public Injector newInjector(final Configuration... confs) + Injector newInjector(final Configuration... confs) throws BindException; /** * Returns an Injector for the given Configuration. */ - public Injector newInjector(final Configuration confs); + Injector newInjector(final Configuration confs); /** * Returns an Injector based on an empty Configuration. */ - public Injector newInjector(); + Injector newInjector(); /** * Return a new ConfigurationBuilder that is backed by the provided @@ -55,7 +55,7 @@ public interface Tang { * @param ch Any valid Tang ClassHierarchy, including ones derived from non-Java application binaries. * @return an instance of ConfigurationBuilder. In Tang's default implementation this returns an instance or JavaConfigurationBuilder if ch is backed by a Java classloader. */ - public ConfigurationBuilder newConfigurationBuilder(ClassHierarchy ch); + ConfigurationBuilder newConfigurationBuilder(ClassHierarchy ch); /** * Create a new ConfigurationBuilder that is backed by the default @@ -66,7 +66,7 @@ public interface Tang { * * @return a new JavaConfigurationBuilder */ - public JavaConfigurationBuilder newConfigurationBuilder(URL... jars); + JavaConfigurationBuilder newConfigurationBuilder(URL... jars); /** * Merge a set of configurations into a new JavaConfiurationBuilder. If @@ -82,7 +82,7 @@ public interface Tang { * conflicting bindings, or if the backing ClassHierarchy objects conflict * in some way. */ - public JavaConfigurationBuilder newConfigurationBuilder(Configuration... confs) + JavaConfigurationBuilder newConfigurationBuilder(Configuration... confs) throws BindException; /** @@ -92,7 +92,7 @@ public interface Tang { * * @return a new ConfigurationBuilder */ - public JavaConfigurationBuilder newConfigurationBuilder(@SuppressWarnings("unchecked") Class<? extends ExternalConstructor<?>>... parameterParsers) + JavaConfigurationBuilder newConfigurationBuilder(@SuppressWarnings("unchecked") Class<? extends ExternalConstructor<?>>... parameterParsers) throws BindException; /** @@ -104,21 +104,21 @@ public interface Tang { * this class for detailed information about each of the parameters to * this method. */ - public JavaConfigurationBuilder newConfigurationBuilder(URL[] jars, - Configuration[] confs, Class<? extends ExternalConstructor<?>>[] parameterParsers) throws BindException; + JavaConfigurationBuilder newConfigurationBuilder(URL[] jars, + Configuration[] confs, Class<? extends ExternalConstructor<?>>[] parameterParsers) throws BindException; /** * Create a new empty ConfigurationBuilder that is backed by the default * classloader. */ - public JavaConfigurationBuilder newConfigurationBuilder(); + JavaConfigurationBuilder newConfigurationBuilder(); /** * @return an instance of JavaClassHierarchy that is backed by the default * Java classloader. ClassHierarchy objects are immutable, so multiple * invocations of this method may return the same instance. */ - public JavaClassHierarchy getDefaultClassHierarchy(); + JavaClassHierarchy getDefaultClassHierarchy(); /** * @return a custom instance of JavaClassHierarchy. ClassHierarchy objects @@ -129,7 +129,7 @@ public interface Tang { * getDefaultClassHierarchy(). If so, we should add a new method like * getNonDefaultClassHiearchy() that takes the same options as this one. */ - public JavaClassHierarchy getDefaultClassHierarchy(URL[] jars, Class<? extends ExternalConstructor<?>>[] parsers); + JavaClassHierarchy getDefaultClassHierarchy(URL[] jars, Class<? extends ExternalConstructor<?>>[] parsers); /** * A factory that returns the default implementation of the Tang interface. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java index 6b1a985..53d5f81 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/timer/Timer.java @@ -24,7 +24,7 @@ import org.apache.reef.tang.annotations.NamedParameter; @DefaultImplementation(TimerImpl.class) public interface Timer { - public void sleep() throws Exception; + void sleep() throws Exception; @NamedParameter(default_value = "10", doc = "Number of seconds to sleep", short_name = "sec") http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java index a20719d..7fec4f6 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java @@ -120,6 +120,7 @@ public final class CommandLine { * @throws ParseException */ @SafeVarargs + @SuppressWarnings("checkstyle:redundantmodifier") final public <T> CommandLine processCommandLine( final String[] args, Class<? extends Name<?>>... argClasses) throws IOException, BindException { @@ -212,6 +213,6 @@ public final class CommandLine { } public interface CommandLineCallback { - public void process(final Option option); + void process(final Option option); } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java index 43d9d11..ae7ebba 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java @@ -72,7 +72,7 @@ public class ConfigurationModule { return cm; } - private final <T> void processSet(Object impl) { + private <T> void processSet(Object impl) { Field f = builder.map.get(impl); if (f == null) { /* throw */ throw new ClassHierarchyException("Unknown Impl/Param when setting " + ReflectionUtilities.getSimpleName(impl.getClass()) + ". Did you pass in a field from some other module?"); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java index da5eb09..6d58f0a 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java @@ -309,7 +309,7 @@ public abstract class ConfigurationModuleBuilder { return c; } - private final <T> void processUse(Object impl) { + private <T> void processUse(Object impl) { Field f = map.get(impl); if (f == null) { /* throw */ throw new ClassHierarchyException("Unknown Impl/Param when binding " + ReflectionUtilities.getSimpleName(impl.getClass()) + ". Did you pass in a field from some other module?"); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java index f286f53..f4b811e 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java @@ -40,7 +40,7 @@ public interface ConfigurationSerializer { * @param file the file to store the Configuration in * @throws java.io.IOException if there is an IO error in the process. */ - public void toFile(final Configuration conf, final File file) throws IOException; + void toFile(final Configuration conf, final File file) throws IOException; /** * Stores the given Configuration in the given Text File. @@ -49,7 +49,7 @@ public interface ConfigurationSerializer { * @param file the file to store the Configuration in * @throws java.io.IOException if there is an IO error in the process. */ - public void toTextFile(final Configuration conf, final File file) throws IOException; + void toTextFile(final Configuration conf, final File file) throws IOException; /** * Writes the Configuration to a byte[]. @@ -58,7 +58,7 @@ public interface ConfigurationSerializer { * @return * @throws IOException */ - public byte[] toByteArray(final Configuration conf) throws IOException; + byte[] toByteArray(final Configuration conf) throws IOException; /** * Writes the Configuration as a String. @@ -66,7 +66,7 @@ public interface ConfigurationSerializer { * @param configuration * @return a String representation of the Configuration */ - public String toString(final Configuration configuration); + String toString(final Configuration configuration); /** @@ -77,7 +77,7 @@ public interface ConfigurationSerializer { * @throws IOException if the File can't be read or parsed * @throws BindException if the file contains an illegal Configuration */ - public Configuration fromFile(final File file) throws IOException, BindException; + Configuration fromFile(final File file) throws IOException, BindException; /** * Loads a Configuration from a File created with toFile(). @@ -87,7 +87,7 @@ public interface ConfigurationSerializer { * @throws IOException if the File can't be read or parsed * @throws BindException if the file contains an illegal Configuration */ - public Configuration fromTextFile(final File file) throws IOException, BindException; + Configuration fromTextFile(final File file) throws IOException, BindException; /** * Loads a Configuration from a File created with toFile() with ClassHierarchy. @@ -97,7 +97,7 @@ public interface ConfigurationSerializer { * @return * @throws IOException */ - public Configuration fromTextFile(final File file, final ClassHierarchy classHierarchy) throws IOException; + Configuration fromTextFile(final File file, final ClassHierarchy classHierarchy) throws IOException; /** * Loads a Configuration from a File created with toFile(). @@ -108,7 +108,7 @@ public interface ConfigurationSerializer { * @throws IOException if the File can't be read or parsed * @throws BindException if the file contains an illegal Configuration */ - public Configuration fromFile(final File file, final ClassHierarchy classHierarchy) throws IOException, BindException; + Configuration fromFile(final File file, final ClassHierarchy classHierarchy) throws IOException, BindException; /** * Loads a Configuration from a byte[] created with toByteArray(). @@ -118,7 +118,7 @@ public interface ConfigurationSerializer { * @throws IOException if the byte[] can't be deserialized * @throws BindException if the byte[] contains an illegal Configuration. */ - public Configuration fromByteArray(final byte[] theBytes) throws IOException, BindException; + Configuration fromByteArray(final byte[] theBytes) throws IOException, BindException; /** * Loads a Configuration from a byte[] created with toByteArray(). @@ -129,7 +129,7 @@ public interface ConfigurationSerializer { * @throws IOException if the byte[] can't be deserialized * @throws BindException if the byte[] contains an illegal Configuration. */ - public Configuration fromByteArray(final byte[] theBytes, final ClassHierarchy classHierarchy) throws IOException, BindException; + Configuration fromByteArray(final byte[] theBytes, final ClassHierarchy classHierarchy) throws IOException, BindException; /** * Decodes a String generated via toString(). @@ -139,7 +139,7 @@ public interface ConfigurationSerializer { * @throws IOException if theString can't be parsed. * @throws BindException if theString contains an illegal Configuration. */ - public Configuration fromString(final String theString) throws IOException, BindException; + Configuration fromString(final String theString) throws IOException, BindException; /** * Decodes a String generated via toString(). @@ -150,5 +150,5 @@ public interface ConfigurationSerializer { * @throws IOException if theString can't be parsed. * @throws BindException if theString contains an illegal Configuration. */ - public Configuration fromString(final String theString, final ClassHierarchy classHierarchy) throws IOException, BindException; + Configuration fromString(final String theString, final ClassHierarchy classHierarchy) throws IOException, BindException; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java index 1cca8f9..042e499 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ClassNode.java @@ -24,24 +24,24 @@ import java.util.Set; public interface ClassNode<T> extends Node { - public ConstructorDef<T>[] getInjectableConstructors(); + ConstructorDef<T>[] getInjectableConstructors(); - public ConstructorDef<T> getConstructorDef(ClassNode<?>... args) + ConstructorDef<T> getConstructorDef(ClassNode<?>... args) throws BindException; - public ConstructorDef<T>[] getAllConstructors(); + ConstructorDef<T>[] getAllConstructors(); - public void putImpl(ClassNode<T> impl); + void putImpl(ClassNode<T> impl); - public Set<ClassNode<T>> getKnownImplementations(); + Set<ClassNode<T>> getKnownImplementations(); - public String getDefaultImplementation(); + String getDefaultImplementation(); - public boolean isUnit(); + boolean isUnit(); - public boolean isInjectionCandidate(); + boolean isInjectionCandidate(); - public boolean isExternalConstructor(); + boolean isExternalConstructor(); - public boolean isImplementationOf(ClassNode<?> inter); + boolean isImplementationOf(ClassNode<?> inter); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java index d2bd091..994afb6 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorArg.java @@ -20,11 +20,11 @@ package org.apache.reef.tang.types; public interface ConstructorArg { - public String getName(); + String getName(); - public String getType(); + String getType(); - public boolean isInjectionFuture(); + boolean isInjectionFuture(); - public String getNamedParameterName(); + String getNamedParameterName(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java index ac3dcc6..0a03ab7 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/ConstructorDef.java @@ -19,11 +19,11 @@ package org.apache.reef.tang.types; public interface ConstructorDef<T> extends Comparable<ConstructorDef<?>> { - public String getClassName(); + String getClassName(); - public ConstructorArg[] getArgs(); + ConstructorArg[] getArgs(); - public boolean isMoreSpecificThan(ConstructorDef<?> def); + boolean isMoreSpecificThan(ConstructorDef<?> def); - public boolean takesParameters(ClassNode<?>[] paramTypes); + boolean takesParameters(ClassNode<?>[] paramTypes); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java index fa4d14c..085d355 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/types/NamedParameterNode.java @@ -20,17 +20,17 @@ package org.apache.reef.tang.types; public interface NamedParameterNode<T> extends Node { - public String getDocumentation(); + String getDocumentation(); - public String getShortName(); + String getShortName(); - public String[] getDefaultInstanceAsStrings(); + String[] getDefaultInstanceAsStrings(); - public String getSimpleArgName(); + String getSimpleArgName(); - public String getFullArgName(); + String getFullArgName(); - public boolean isSet(); + boolean isSet(); - public boolean isList(); + boolean isList(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java index 130e93f..c559761 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java @@ -426,7 +426,7 @@ public class Tint { } } - private final boolean classFilter(boolean checkTang, String s) { + private boolean classFilter(boolean checkTang, String s) { return (checkTang || /*s.startsWith("org.apache.reef.tang.examples.timer") ||*/ !s.startsWith("org.apache.reef.tang")); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java b/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java index 9e5bd53..8621bcc 100644 --- a/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java +++ b/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/logging/DFSHandler.java @@ -49,7 +49,7 @@ public final class DFSHandler extends Handler { this.streamHandler = new StreamHandler(logOutputStream, logFormatter); } - private static final <T> T getInstance(final String className, final T defaultValue) { + private static <T> T getInstance(final String className, final T defaultValue) { try { final Class aClass = ClassLoader.getSystemClassLoader().loadClass(className); return (T) aClass.newInstance(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java index c6a8a79..c6ceebb 100644 --- a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java +++ b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/Cache.java @@ -36,13 +36,13 @@ public interface Cache<K, V> { * @return a value * @throws ExecutionException */ - public V get(K key, Callable<V> valueFetcher) throws ExecutionException; + V get(K key, Callable<V> valueFetcher) throws ExecutionException; /** * Invalidates a key from the cache. * * @param key a key */ - public void invalidate(K key); + void invalidate(K key); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java index 318cd77..14e1332 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/EventHandler.java @@ -30,5 +30,5 @@ public interface EventHandler<T> { * * @param value an event */ - public void onNext(T value); + void onNext(T value); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java index d94f05b..8387c2e 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifiable.java @@ -25,6 +25,6 @@ public interface Identifiable { * * @return an identifier of this object */ - public Identifier getId(); + Identifier getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java index 9884197..f73b53f 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/Identifier.java @@ -33,7 +33,7 @@ public interface Identifier { * * @return a hash code value for this object */ - public int hashCode(); + int hashCode(); /** * Checks that another object is equal to this object. @@ -42,13 +42,13 @@ public interface Identifier { * @return true if the object is the same as the object argument; false, * otherwise */ - public boolean equals(Object o); + boolean equals(Object o); /** * Return a string representation of this object. This method should return a * URL-style string, that begins with "type://", where "type" is chosen to * uniquely identify this type of identifier. */ - public String toString(); + String toString(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java index 583d131..82516fa 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierFactory.java @@ -26,6 +26,6 @@ public interface IdentifierFactory { * @param str a string * @return an identifier */ - public Identifier getNewInstance(String str); + Identifier getNewInstance(String str); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java index 952f960..2b6f5cd 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/EventSource.java @@ -29,5 +29,5 @@ public interface EventSource<T> { /** * @return a event or null if no more messages are available. */ - public T getNext(); + T getNext(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java index dd3d7ee..1f1fd34 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/p2p/Pull2Push.java @@ -56,7 +56,7 @@ public final class Pull2Push<T> implements Runnable, AutoCloseable { * @param source The source that will be added to the queue of this * Pull2Push */ - public final void register(final EventSource<T> source) { + public void register(final EventSource<T> source) { this.sources.add(source); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java index 2c84274..d27b719 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java @@ -51,7 +51,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> { } @Override - public final void onNext(final T event) { + public void onNext(final T event) { this.events.add(event); int newCursor = this.cursor.incrementAndGet(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java index bdb66e2..7b582bb 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java @@ -46,7 +46,7 @@ public final class BlockingSignalEventHandler<T> implements EventHandler<T> { } @Override - public final void onNext(final T event) { + public void onNext(final T event) { int newSize = this.cursor.incrementAndGet(); if (newSize % expectedSize == 0) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java index c348c67..5870447 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Histogram.java @@ -28,14 +28,14 @@ public interface Histogram { * * @param value the new value */ - public void update(long value); + void update(long value); /** * Returns the number of recorded values. * * @return the number of recorded values */ - public long getCount(); + long getCount(); /** * Returns the value of the index. @@ -44,12 +44,12 @@ public interface Histogram { * @return the value of the index * @throws IndexOutOfBoundsException */ - public long getValue(int index); + long getValue(int index); /** * Returns the number of bins. * * @return the number of bins */ - public int getNumBins(); + int getNumBins(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java index bdb88dd..6383ab4 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/Decoder.java @@ -32,5 +32,5 @@ public interface Decoder<T> { * @param buf * @return the decoded object */ - public T decode(byte[] data); + T decode(byte[] data); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java index ef1b11f..9670ada 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteIdentifierFactory.java @@ -37,5 +37,5 @@ public interface RemoteIdentifierFactory extends IdentifierFactory { * @return a remote identifier */ @Override - public RemoteIdentifier getNewInstance(String str); + RemoteIdentifier getNewInstance(String str); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java index 12c4a0c..e954ec3 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java @@ -42,7 +42,7 @@ public interface RemoteManager extends Stage { * @param messageType a message class type * @return an event handler */ - public <T> EventHandler<T> getHandler(final RemoteIdentifier destinationIdentifier, final Class<? extends T> messageType); + <T> EventHandler<T> getHandler(final RemoteIdentifier destinationIdentifier, final Class<? extends T> messageType); /** * Registers the given EventHandler to be invoked when messages of Type T @@ -56,7 +56,7 @@ public interface RemoteManager extends Stage { * @param theHandler the event handler * @return the subscription that can be used to unsubscribe later */ - public <T, U extends T> AutoCloseable registerHandler(final RemoteIdentifier sourceIdentifier, final Class<U> messageType, final EventHandler<T> theHandler); + <T, U extends T> AutoCloseable registerHandler(final RemoteIdentifier sourceIdentifier, final Class<U> messageType, final EventHandler<T> theHandler); /** * Registers the given EventHandler to be called for the given message type @@ -69,7 +69,7 @@ public interface RemoteManager extends Stage { * @param theHandler the event handler * @return the subscription that can be used to unsubscribe later */ - public <T, U extends T> AutoCloseable registerHandler(final Class<U> messageType, final EventHandler<RemoteMessage<T>> theHandler); + <T, U extends T> AutoCloseable registerHandler(final Class<U> messageType, final EventHandler<RemoteMessage<T>> theHandler); /** * Register an EventHandler that gets called by Wake in the presence of @@ -80,12 +80,12 @@ public interface RemoteManager extends Stage { * @return the subscription that can be used to unsubscribe later */ @Deprecated - public AutoCloseable registerErrorHandler(final EventHandler<Exception> theHandler); + AutoCloseable registerErrorHandler(final EventHandler<Exception> theHandler); /** * Access the Identifier of this. * * @return the Identifier of this. */ - public RemoteIdentifier getMyIdentifier(); + RemoteIdentifier getMyIdentifier(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java index f43fbb8..7dcba73 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteMessage.java @@ -30,13 +30,13 @@ public interface RemoteMessage<T> { * * @return a remote identifier */ - public RemoteIdentifier getIdentifier(); + RemoteIdentifier getIdentifier(); /** * Returns an actual message. * * @return a message */ - public T getMessage(); + T getMessage(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java index e54f030..478b9ec 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/LinkListener.java @@ -32,7 +32,7 @@ public interface LinkListener<T> { * * @param message the sent message */ - public void onSuccess(T message); + void onSuccess(T message); /** * Called when the sent message to remoteAddress is failed to be transferred. @@ -41,5 +41,5 @@ public interface LinkListener<T> { * @param remoteAddress the exception occurred remote address * @param message the send message */ - public void onException(Throwable cause, SocketAddress remoteAddress, T message); + void onException(Throwable cause, SocketAddress remoteAddress, T message); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java index 424453c..9979588 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/Transport.java @@ -44,7 +44,7 @@ public interface Transport extends Stage { * @return a link associated with the address * @throws IOException */ - public <T> Link<T> open(SocketAddress remoteAddr, Encoder<? super T> encoder, LinkListener<? super T> listener) throws IOException; + <T> Link<T> open(SocketAddress remoteAddr, Encoder<? super T> encoder, LinkListener<? super T> listener) throws IOException; /** * Returns a link for the remote address if already cached; otherwise, returns null. @@ -52,26 +52,26 @@ public interface Transport extends Stage { * @param remoteAddr the remote address * @return a link if already cached; otherwise, null */ - public <T> Link<T> get(SocketAddress remoteAddr); + <T> Link<T> get(SocketAddress remoteAddr); /** * Gets a server listening port of this transport. * * @return a listening port number */ - public int getListeningPort(); + int getListeningPort(); /** * Gets a server local socket address of this transport. * * @return a server local socket address */ - public SocketAddress getLocalAddress(); + SocketAddress getLocalAddress(); /** * Registers the exception handler. * * @param handler the exception handler */ - public void registerErrorHandler(EventHandler<Exception> handler); + void registerErrorHandler(EventHandler<Exception> handler); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java index e126013..a58da0e 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java @@ -40,10 +40,10 @@ public interface TransportFactory { * @param exHandler an exception handler * @return transport */ - public Transport newInstance(int port, - EventHandler<TransportEvent> clientHandler, - EventHandler<TransportEvent> serverHandler, - EventHandler<Exception> exHandler); + Transport newInstance(int port, + EventHandler<TransportEvent> clientHandler, + EventHandler<TransportEvent> serverHandler, + EventHandler<Exception> exHandler); /** * Creates a transport. @@ -56,11 +56,11 @@ public interface TransportFactory { * @param retryTimeout retry timeout * @return transport */ - public Transport newInstance(final String hostAddress, int port, - final EStage<TransportEvent> clientStage, - final EStage<TransportEvent> serverStage, - final int numberOfTries, - final int retryTimeout); + Transport newInstance(final String hostAddress, int port, + final EStage<TransportEvent> clientStage, + final EStage<TransportEvent> serverStage, + final int numberOfTries, + final int retryTimeout); /** * Creates a transport. @@ -74,13 +74,13 @@ public interface TransportFactory { * @param tcpPortProvider tcpPortProvider * @return transport */ - public Transport newInstance(final String hostAddress, - int port, - final EStage<TransportEvent> clientStage, - final EStage<TransportEvent> serverStage, - final int numberOfTries, - final int retryTimeout, - final TcpPortProvider tcpPortProvider); + Transport newInstance(final String hostAddress, + int port, + final EStage<TransportEvent> clientStage, + final EStage<TransportEvent> serverStage, + final int numberOfTries, + final int retryTimeout, + final TcpPortProvider tcpPortProvider); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java index 7004191..10de932 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java @@ -32,7 +32,7 @@ public interface Observer<T> { * * @param value */ - public void onNext(final T value); + void onNext(final T value); /** * Notifies the observer that the provider has experienced an error @@ -40,11 +40,11 @@ public interface Observer<T> { * * @param error */ - public void onError(final Exception error); + void onError(final Exception error); /** * Notifies the observer that the provider has finished sending push-based * notifications. */ - public void onCompleted(); + void onCompleted(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java index 0172df2..639ce02 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java @@ -48,27 +48,27 @@ public interface Clock extends Runnable, AutoCloseable { * @param offset into the future * @throws IllegalStateException when the clock has been already closed */ - public void scheduleAlarm(final int offset, final EventHandler<Alarm> handler); + void scheduleAlarm(final int offset, final EventHandler<Alarm> handler); /** * This will stop the clock after all client alarms * finish executing. */ @Override - public void close(); + void close(); /** * This stops the clock immediately, without waiting for * client alarms to finish. */ - public void stop(); + void stop(); /** * Clock is idle if it has no future Alarms set. * * @return true if idle, otherwise false */ - public boolean isIdle(); + boolean isIdle(); /** * Bind this to an event handler to statically subscribe to the StartTime Event. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java index 6149db4..e52d759 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/RuntimeClock.java @@ -74,7 +74,7 @@ public final class RuntimeClock implements Clock { } @Override - public final void scheduleAlarm(final int offset, final EventHandler<Alarm> handler) { + public void scheduleAlarm(final int offset, final EventHandler<Alarm> handler) { synchronized (this.schedule) { if (this.closed) { throw new IllegalStateException("Scheduling alarm on a closed clock"); @@ -85,11 +85,11 @@ public final class RuntimeClock implements Clock { } } - public final void registerEventHandler(final Class<? extends Time> clazz, final EventHandler<Time> handler) { + public void registerEventHandler(final Class<? extends Time> clazz, final EventHandler<Time> handler) { this.handlers.subscribe(clazz, handler); } - public final void scheduleRuntimeAlarm(final int offset, final EventHandler<Alarm> handler) { + public void scheduleRuntimeAlarm(final int offset, final EventHandler<Alarm> handler) { synchronized (this.schedule) { this.schedule.add(new RuntimeAlarm(this.timer.getCurrent() + offset, handler)); this.schedule.notifyAll(); @@ -97,7 +97,7 @@ public final class RuntimeClock implements Clock { } @Override - public final void stop() { + public void stop() { LOG.entering(RuntimeClock.class.getCanonicalName(), "stop"); synchronized (this.schedule) { this.schedule.clear(); @@ -109,7 +109,7 @@ public final class RuntimeClock implements Clock { } @Override - public final void close() { + public void close() { LOG.entering(RuntimeClock.class.getCanonicalName(), "close"); synchronized (this.schedule) { if (this.closed) { @@ -132,7 +132,7 @@ public final class RuntimeClock implements Clock { * * @return an acceptable stop time */ - private final long findAcceptableStopTime() { + private long findAcceptableStopTime() { long time = timer.getCurrent(); for (Time t : this.schedule) { if (t instanceof ClientAlarm) { @@ -145,7 +145,7 @@ public final class RuntimeClock implements Clock { @Override - public final boolean isIdle() { + public boolean isIdle() { synchronized (this.schedule) { for (Time t : this.schedule) { if (t instanceof ClientAlarm) { @@ -156,7 +156,7 @@ public final class RuntimeClock implements Clock { } } - private final <T extends Time> void subscribe(final Class<T> eventClass, final Set<EventHandler<T>> handlers) { + private <T extends Time> void subscribe(final Class<T> eventClass, final Set<EventHandler<T>> handlers) { for (final EventHandler<T> handler : handlers) { this.handlers.subscribe(eventClass, handler); } @@ -178,7 +178,7 @@ public final class RuntimeClock implements Clock { } @Override - public final void run() { + public void run() { LOG.entering(RuntimeClock.class.getCanonicalName(), "run"); try { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java index a58f76e..6104c26 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java @@ -34,7 +34,7 @@ public interface DriverInfoSerializer { * @param startTime * @return AvroDriverInfo object */ - public AvroDriverInfo toAvro(final String id, final String startTime, final List<AvroReefServiceInfo> services); + AvroDriverInfo toAvro(final String id, final String startTime, final List<AvroReefServiceInfo> services); /** * Convert AvroDriverInfo object to JSon string. @@ -42,5 +42,5 @@ public interface DriverInfoSerializer { * @param avroDriverInfo * @return */ - public String toString(final AvroDriverInfo avroDriverInfo); + String toString(final AvroDriverInfo avroDriverInfo); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java index d9575d7..3acfd92 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java @@ -36,7 +36,7 @@ public interface EvaluatorListSerializer { * @param startTime * @return */ - public AvroEvaluatorList toAvro(final Map<String, EvaluatorDescriptor> evaluatorMap, final int totalEvaluators, final String startTime); + AvroEvaluatorList toAvro(final Map<String, EvaluatorDescriptor> evaluatorMap, final int totalEvaluators, final String startTime); /** * Convert AvroEvaluatorList to JSon string. @@ -44,5 +44,5 @@ public interface EvaluatorListSerializer { * @param avroEvaluatorList * @return */ - public String toString(final AvroEvaluatorList avroEvaluatorList); + String toString(final AvroEvaluatorList avroEvaluatorList); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java index 4315924..128e187 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java @@ -31,14 +31,14 @@ public interface HttpHandler { * * @return */ - public String getUriSpecification(); + String getUriSpecification(); /** * return specification of the handler. e.g Reef * * @return */ - public void setUriSpecification(final String s); + void setUriSpecification(final String s); /** * Will be called when request comes. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java index 73e1705..d49d774 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java @@ -28,26 +28,26 @@ public interface HttpServer { * * @throws Exception */ - public void start() throws Exception; + void start() throws Exception; /** * stop the server. * * @throws Exception */ - public void stop() throws Exception; + void stop() throws Exception; /** * get port number of the server. * * @return */ - public int getPort(); + int getPort(); /** * Add a httpHandler to the server. * * @param httpHandler */ - public void addHttpHandler(final HttpHandler httpHandler); + void addHttpHandler(final HttpHandler httpHandler); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java index 5992e5f..2835421 100644 --- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java +++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpTrackingURLProvider.java @@ -56,7 +56,7 @@ public final class HttpTrackingURLProvider implements TrackingURLProvider { * @return */ @Override - public final String getTrackingUrl() { + public String getTrackingUrl() { try { return InetAddress.getLocalHost().getHostAddress() + ":" + httpServer.getPort(); } catch (final UnknownHostException e) {
