Repository: incubator-reef
Updated Branches:
  refs/heads/master d5baddfdd -> b3c1517bf


[REEF-401] Triage TODO comments in Java code, part 1: introduce TODO[JIRA ...] 
format

This addressed the issue by
  * Introducing different severities of TodoComment check depending on
    whether TODO is followed by [JIRA ...] or not

This change does not enforce new format of TODOs yet.

JIRA:
  [REEF-401](https://issues.apache.org/jira/browse/REEF-401)

Pull Request:
  This closes #249


Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/b3c1517b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/b3c1517b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/b3c1517b

Branch: refs/heads/master
Commit: b3c1517bf7f23587b7ee532864b7203c5a54fd12
Parents: d5baddf
Author: Mariia Mykhailova <[email protected]>
Authored: Fri Jun 26 11:34:11 2015 -0700
Committer: Markus Weimer <[email protected]>
Committed: Fri Jun 26 13:23:05 2015 -0700

----------------------------------------------------------------------
 lang/java/reef-common/src/main/resources/checkstyle.xml | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b3c1517b/lang/java/reef-common/src/main/resources/checkstyle.xml
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/resources/checkstyle.xml 
b/lang/java/reef-common/src/main/resources/checkstyle.xml
index f694403..ce2b553 100644
--- a/lang/java/reef-common/src/main/resources/checkstyle.xml
+++ b/lang/java/reef-common/src/main/resources/checkstyle.xml
@@ -225,6 +225,11 @@
         </module>
         <module name="TodoComment">
             <property name="severity" value="warning"/>
+            <property name="format" value="TODO[^\[][^J][^I][^R][^A]"/>
+        </module>
+        <module name="TodoComment">
+            <property name="severity" value="info"/>
+            <property name="format" value="TODO\[JIRA"/>
         </module>
         <module name="UpperEll"/>
     </module>

Reply via email to