Repository: incubator-reef Updated Branches: refs/heads/master 073f18e40 -> 58811a7cc
[REEF-696] Adjust access-level of injected constructors in reef-examples/scheduler Convert TANG-injected constructors to private. JIRA: [REEF-696](https://issues.apache.org/jira/browse/REEF-696) Pull Request: Closes #441 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/58811a7c Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/58811a7c Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/58811a7c Branch: refs/heads/master Commit: 58811a7cc7e8f73c4e55303dc2f7e71e5f3d7cee Parents: 073f18e Author: Brian Cho <chobr...@apache.org> Authored: Sun Aug 30 22:26:26 2015 +0900 Committer: Yunseong Lee <yunse...@apache.org> Committed: Mon Aug 31 01:51:38 2015 +0900 ---------------------------------------------------------------------- .../java/org/apache/reef/examples/scheduler/Scheduler.java | 2 +- .../org/apache/reef/examples/scheduler/SchedulerDriver.java | 6 +++--- .../apache/reef/examples/scheduler/SchedulerHttpHandler.java | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/58811a7c/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java index 4677c08..0c79172 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/Scheduler.java @@ -59,7 +59,7 @@ final class Scheduler { private final AtomicInteger taskCount = new AtomicInteger(0); @Inject - public Scheduler() { + private Scheduler() { taskQueue = new LinkedBlockingQueue<>(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/58811a7c/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java index 0b956de..d8a7059 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerDriver.java @@ -76,9 +76,9 @@ public final class SchedulerDriver { private final EvaluatorRequestor requestor; @Inject - public SchedulerDriver(final EvaluatorRequestor requestor, - @Parameter(SchedulerREEF.Retain.class) final boolean retainable, - final Scheduler scheduler) { + private SchedulerDriver(final EvaluatorRequestor requestor, + @Parameter(SchedulerREEF.Retain.class) final boolean retainable, + final Scheduler scheduler) { this.requestor = requestor; this.scheduler = scheduler; this.retainable = retainable; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/58811a7c/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java index c8fd8f3..f390370 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerHttpHandler.java @@ -38,7 +38,7 @@ final class SchedulerHttpHandler implements HttpHandler { private String uriSpecification = "reef-example-scheduler"; @Inject - public SchedulerHttpHandler(final InjectionFuture<SchedulerDriver> schedulerDriver) { + private SchedulerHttpHandler(final InjectionFuture<SchedulerDriver> schedulerDriver) { this.schedulerDriver = schedulerDriver; }
