Copilot commented on code in PR #126: URL: https://github.com/apache/incubator-resilientdb-blog/pull/126#discussion_r2424977117
########## _posts/2024-09-13-SmartContractsGraphQL.md: ########## @@ -58,7 +77,7 @@ Launch the GraphQL API server: node server.js ``` -Your server will be up and running on port 4000. Access the GraphQL API at http://localhost:4000/graphql. +Your server will be up and running on port 8400. Access the GraphQL API at http://localhost:8400/graphql. Review Comment: The port number has been changed from 4000 to 8400, but this should be verified to ensure consistency across all documentation and that the actual service runs on this port. ########## _posts/2024-09-13-SmartContractsGraphQL.md: ########## @@ -72,12 +91,24 @@ Generate a new account using a configuration file. } ``` +**Add Address** +Add an existing address to the configuration. + +```graphql +{ + addAddress( + config: "path/to/config/file", + address: "0xAddressToAdd" + ) +} +``` + **Compile Contract** Compile a smart contract from a source file and save the output. ```graphql { - compileContract(sourcePath: "path/to/source/file", outputPath: "path/to/output/file") + compileContract(source: "path/to/source/file") Review Comment: The parameter name changed from 'sourcePath' to 'source', but the example value still shows 'path/to/source/file' which suggests it's still a path. This inconsistency between parameter naming and usage could confuse users. ```suggestion compileContract(sourcePath: "path/to/source/file") ``` ########## _posts/2024-09-13-SmartContractsGraphQL.md: ########## @@ -104,8 +135,8 @@ Execute a function of a deployed smart contract. executeContract( config: "path/to/config/file", sender: "senderAddress", - contract: "contractName", - function: "functionName", + contract: "contractAddress", Review Comment: The parameter names have changed from 'contract'/'function' to 'contract'/'functionName', but the documentation shows 'contractAddress'/'functionName' as values. The parameter should be clarified - if 'contract' expects an address, it should be named 'contractAddress' for consistency. ```suggestion contractAddress: "contractAddress", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
