Author: peter_firmstone Date: Sun Mar 10 06:24:09 2013 New Revision: 1454795
URL: http://svn.apache.org/r1454795 Log: After changing startTimeout to volatile, the test later failed again after repeated runs, with the same cause appended below. This commit doubles the default Mux startTimout and connection timeouts to 30 seconds. Test failure: com/sun/jini/test/impl/outrigger/matching/StressTestWithShutdown.td [java] java.rmi.ConnectIOException: I/O exception connecting to BasicObjectEndpoint[049eaa35-f725-490f-89b4-f32f064dba0d,TcpEndpoint[10.1.1.2:56674]]; nested exception is: [java] java.io.IOException: timeout waiting for server to respond to handshake [java] at net.jini.jeri.BasicInvocationHandler.wrapSafeIOException(BasicInvocationHandler.java:893) [java] at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethodOnce(BasicInvocationHandler.java:711) [java] at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethod(BasicInvocationHandler.java:659) [java] at net.jini.jeri.BasicInvocationHandler.invoke(BasicInvocationHandler.java:528) [java] at com.sun.jini.outrigger.$Proxy1.write(Unknown Source) [java] at com.sun.jini.outrigger.SpaceProxy2.write(SpaceProxy2.java:296) [java] at com.sun.jini.test.impl.outrigger.matching.StressTest$WriteRandomEntryTask.spaceWrite(StressTest.java:585) [java] at com.sun.jini.test.impl.outrigger.matching.StressTest$WriteRandomEntryTask.run(StressTest.java:548) [java] at com.sun.jini.thread.TaskManager$TaskThread.run(TaskManager.java:331) [java] Caused by: java.io.IOException: timeout waiting for server to respond to handshake [java] at com.sun.jini.jeri.internal.mux.Mux.start(Mux.java:240) [java] at com.sun.jini.jeri.internal.mux.MuxClient.start(MuxClient.java:35) [java] at net.jini.jeri.connection.ConnectionManager$OutboundMux.newRequest(ConnectionManager.java:375) [java] at net.jini.jeri.connection.ConnectionManager$ReqIterator.next(ConnectionManager.java:665) [java] at net.jini.jeri.BasicObjectEndpoint$1.next(BasicObjectEndpoint.java:370) [java] at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethodOnce(BasicInvocationHandler.java:708) [java] ... 7 more Modified: river/jtsk/skunk/qa_refactor/trunk/src/com/sun/jini/jeri/internal/mux/Mux.java river/jtsk/skunk/qa_refactor/trunk/src/net/jini/jeri/connection/ConnectionManager.java Modified: river/jtsk/skunk/qa_refactor/trunk/src/com/sun/jini/jeri/internal/mux/Mux.java URL: http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/src/com/sun/jini/jeri/internal/mux/Mux.java?rev=1454795&r1=1454794&r2=1454795&view=diff ============================================================================== --- river/jtsk/skunk/qa_refactor/trunk/src/com/sun/jini/jeri/internal/mux/Mux.java (original) +++ river/jtsk/skunk/qa_refactor/trunk/src/com/sun/jini/jeri/internal/mux/Mux.java Sun Mar 10 06:24:09 2013 @@ -139,7 +139,7 @@ abstract class Mux { private int expectedPingCookie = -1; /** unguarded instance state */ - private volatile long startTimeout = 15000; // milliseconds + private volatile long startTimeout = 30000; // milliseconds /** * Constructs a new Mux instance for a connection accessible through Modified: river/jtsk/skunk/qa_refactor/trunk/src/net/jini/jeri/connection/ConnectionManager.java URL: http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/src/net/jini/jeri/connection/ConnectionManager.java?rev=1454795&r1=1454794&r2=1454795&view=diff ============================================================================== --- river/jtsk/skunk/qa_refactor/trunk/src/net/jini/jeri/connection/ConnectionManager.java (original) +++ river/jtsk/skunk/qa_refactor/trunk/src/net/jini/jeri/connection/ConnectionManager.java Sun Mar 10 06:24:09 2013 @@ -104,11 +104,11 @@ import net.jini.jeri.OutboundRequestIter * * <li><code>com.sun.jini.jeri.connectionTimeout</code> - Time in * milliseconds to leave idle client-side connections around before - * closing them. The default value is 15000 milliseconds (15 seconds). + * closing them. The default value is 30000 milliseconds (30 seconds). * * <li><code>com.sun.jini.jeri.handshakeTimeout</code> - Time in * milliseconds for client-side connections to wait for the server to - * acknowledge an opening handshake. The default value is 15000 milliseconds (15 seconds). + * acknowledge an opening handshake. The default value is 30000 milliseconds (30 seconds). * * </ul> **/ @@ -119,14 +119,14 @@ public final class ConnectionManager { private static final long TIMEOUT = ( (Long) AccessController.doPrivileged(new GetLongAction( "com.sun.jini.jeri.connectionTimeout", - 15000))).longValue(); + 30000))).longValue(); /** * How long to wait for a server to respond to an initial client message. */ private static final long HANDSHAKE_TIMEOUT = ((Long) AccessController.doPrivileged(new GetLongAction( "com.sun.jini.jeri.handshakeTimeout", - 15000))).longValue(); + 30000))).longValue(); /** * ConnectionManager logger. */
