Author: peter_firmstone
Date: Sun Jul 28 09:51:01 2013
New Revision: 1507773

URL: http://svn.apache.org/r1507773
Log:
Some tests are currently failing on Windows Server x64 Java 7.  There appears 
to be an issue with system time, as indicated by the following test output:

com.sun.jini.qa.harness.TestException: Environment problem; this configuration 
does not allow for the timing assumptions made by the test
        at 
com.sun.jini.test.spec.lookupservice.QATestUtils.computeDurAndWait(QATestUtils.java:424)
        at 
com.sun.jini.test.spec.lookupservice.test_set00.MultipleSrvcLeaseRenewals.run(MultipleSrvcLeaseRenewals.java:137)
        at com.sun.jini.qa.harness.MasterTest.doTest(MasterTest.java:256)
        at com.sun.jini.qa.harness.MasterTest.main(MasterTest.java:144)

Modified lookupservice tests to check that thread wake up for lease renewal 
occurs after desired wait period, but before lease expiration

Modified:
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/QATestUtils.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleEvntLeaseRenewals.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleSrvcLeaseRenewals.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/SrvcLeaseExpiration.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredAddAttributes.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseCancel.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseRenew.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapCancel.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapRenew.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredModifyAttributes.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseCancel.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseRenew.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredSetAttributes.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/LeaseMapRenew.java

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/QATestUtils.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/QATestUtils.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/QATestUtils.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/QATestUtils.java
 Sun Jul 28 09:51:01 2013
@@ -412,13 +412,14 @@ public class QATestUtils {
      *  @param deltaT time increment
      *  @exception TestException usually indicates a failure
      */
-    public static void computeDurAndWait(long baseT0, long deltaT, Object 
lock) throws Exception
+    public static void computeDurAndWait(long baseT0, long deltaT, long 
deltaTLimit, Object lock) throws Exception
     {
         long finishTime = baseT0 + deltaT;
         long dur = finishTime - System.currentTimeMillis();
        if(dur > 0) {
             do {
                 synchronized (lock) { lock.wait(dur); }
+                if ( deltaTLimit > 0 && dur > deltaTLimit) throw new 
TestException("Waited too long, exceeded limit, possibly due to lock 
contention");
             } while (finishTime > System.currentTimeMillis()); // In case of 
spurious wakeup or notify.
        } else {
             throw new TestException("Environment problem; this configuration"

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleEvntLeaseRenewals.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleEvntLeaseRenewals.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleEvntLeaseRenewals.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleEvntLeaseRenewals.java
 Sun Jul 28 09:51:01 2013
@@ -187,7 +187,7 @@ public class MultipleEvntLeaseRenewals e
            logger.log(Level.FINE, "\n**** Start trial #" + i + "****");
            logger.log(Level.FINE, "Waiting 3/4 of lease duration time.");
            numEvnt = 0;
-           QATestUtils.computeDurAndWait(leaseStartTime, leaseWaitTime, this);
+           QATestUtils.computeDurAndWait(leaseStartTime, leaseWaitTime, 0, 
this);
            logger.log(Level.FINE, "Renewing leases ...");
            leaseStartTime = QATestUtils.getCurTime();
            QATestUtils.doRenewLease(evntLeases, leaseDuration);
@@ -197,7 +197,7 @@ public class MultipleEvntLeaseRenewals e
                                     leaseStartTime + leaseDuration);
            logger.log(Level.FINE, "Waiting 1/2 of the lease duration time.");
            QATestUtils.computeDurAndWait(leaseStartTime, 
-                                         halfDurationTime, this);
+                                         halfDurationTime, 0, this);
 
            String transitionText = null;
            int transition;

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleSrvcLeaseRenewals.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleSrvcLeaseRenewals.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleSrvcLeaseRenewals.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/MultipleSrvcLeaseRenewals.java
 Sun Jul 28 09:51:01 2013
@@ -134,7 +134,7 @@ public class MultipleSrvcLeaseRenewals e
        for(int i =0; i<loopCount; i++) {
            logger.log(Level.FINE, "\n**** Start trial #" + i + "****");
            logger.log(Level.FINE, "Waiting 3/4 of lease duration time.");
-           QATestUtils.computeDurAndWait(leaseStartTime, leaseWaitTime, this);
+           QATestUtils.computeDurAndWait(leaseStartTime, leaseWaitTime, 
leaseDuration, this);
            leaseStartTime = QATestUtils.getCurTime();
            logger.log(Level.FINE, "Renewing leases ...");
            QATestUtils.doRenewLease(srvcLeases, leaseDuration);
@@ -144,7 +144,7 @@ public class MultipleSrvcLeaseRenewals e
                                     leaseStartTime + leaseDuration);
            logger.log(Level.FINE, "Waiting 1/2 of the lease duration time.");
            QATestUtils.computeDurAndWait(leaseStartTime, 
-                                         halfDurationTime, this);
+                                         halfDurationTime, leaseDuration, 
this);
            logger.log(Level.FINE, "Asserting that each service proxy " +
                              "can still be found.");
            QATestUtils.doLookup(srvcItems, srvcIDTmpls, proxy ); 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/SrvcLeaseExpiration.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/SrvcLeaseExpiration.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/SrvcLeaseExpiration.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set00/SrvcLeaseExpiration.java
 Sun Jul 28 09:51:01 2013
@@ -121,7 +121,7 @@ public class SrvcLeaseExpiration extends
 
        logger.log(Level.FINE, "Waiting " + (leaseDuration*2) + 
                          " milliseconds for service leases to expire.");
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration*2, this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration*2, 0, this);
 
        logger.log(Level.FINE, "Checking that no services can be found.");
        doLookupNoMatch();

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredAddAttributes.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredAddAttributes.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredAddAttributes.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredAddAttributes.java
 Sun Jul 28 09:51:01 2013
@@ -68,7 +68,7 @@ public class ExpiredAddAttributes extend
 
     /** Executes the current QA test. */
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doAddAttributes();
     }
 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseCancel.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseCancel.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseCancel.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseCancel.java
 Sun Jul 28 09:51:01 2013
@@ -116,7 +116,7 @@ public class ExpiredEventLeaseCancel ext
    }
 
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doLeaseCancel();
     }
 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseRenew.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseRenew.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseRenew.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredEventLeaseRenew.java
 Sun Jul 28 09:51:01 2013
@@ -116,7 +116,7 @@ public class ExpiredEventLeaseRenew exte
    }
 
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doLeaseRenew();
     }
 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapCancel.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapCancel.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapCancel.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapCancel.java
 Sun Jul 28 09:51:01 2013
@@ -120,7 +120,7 @@ public class ExpiredLeaseMapCancel exten
    }
 
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doLeaseMapCancel();
        if (!leaseMap.isEmpty())
            throw new TestException("map is not empty");

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapRenew.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapRenew.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapRenew.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredLeaseMapRenew.java
 Sun Jul 28 09:51:01 2013
@@ -120,7 +120,7 @@ public class ExpiredLeaseMapRenew extend
    }
 
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doLeaseMapRenew();
        if (!leaseMap.isEmpty())
            throw new TestException("Map is not empty");

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredModifyAttributes.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredModifyAttributes.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredModifyAttributes.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredModifyAttributes.java
 Sun Jul 28 09:51:01 2013
@@ -71,7 +71,7 @@ public class ExpiredModifyAttributes ext
 
     /** Executes the current QA test. */
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doModifyAttributes();
     }
 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseCancel.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseCancel.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseCancel.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseCancel.java
 Sun Jul 28 09:51:01 2013
@@ -70,7 +70,7 @@ public class ExpiredServiceLeaseCancel e
 
     /** Executes the current QA test. */
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doLeaseCancel();
     }
 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseRenew.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseRenew.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseRenew.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredServiceLeaseRenew.java
 Sun Jul 28 09:51:01 2013
@@ -69,7 +69,7 @@ public class ExpiredServiceLeaseRenew ex
 
     /** Executes the current QA test. */
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doLeaseRenew();
     }
 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredSetAttributes.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredSetAttributes.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredSetAttributes.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/ExpiredSetAttributes.java
 Sun Jul 28 09:51:01 2013
@@ -67,7 +67,7 @@ public class ExpiredSetAttributes extend
 
     /** Executes the current QA test. */
     public synchronized void run() throws Exception {
-       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 
this);
+       QATestUtils.computeDurAndWait(leaseStartTime, leaseDuration + 1000, 0, 
this);
        doSetAttributes();
     }
 

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/LeaseMapRenew.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/LeaseMapRenew.java?rev=1507773&r1=1507772&r2=1507773&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/LeaseMapRenew.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/lookupservice/test_set02/LeaseMapRenew.java
 Sun Jul 28 09:51:01 2013
@@ -168,7 +168,7 @@ public class LeaseMapRenew extends QATes
     public synchronized void run() throws Exception {
        for(int i =0; i<loopCount; i++) {
            logger.log(Level.FINEST, "renewLeaseWait: " + i);
-           QATestUtils.computeDurAndWait(leaseStartTime, leaseWaitTime, this);
+           QATestUtils.computeDurAndWait(leaseStartTime, leaseWaitTime, 0, 
this);
            logger.log(Level.FINEST, "doRenewLease");
            leaseStartTime = QATestUtils.getCurTime();
            leaseMap.renewAll(); 
@@ -179,7 +179,7 @@ public class LeaseMapRenew extends QATes
            if (!mapCopy.equals(leaseMap))
                throw new TestException("map contents changed");
            logger.log(Level.FINEST, "lookupwait");
-           QATestUtils.computeDurAndWait(leaseStartTime, halfDurationTime, 
this);
+           QATestUtils.computeDurAndWait(leaseStartTime, halfDurationTime, 0, 
this);
            logger.log(Level.FINEST, "dolookup");
            QATestUtils.doLookup(srvcItems, srvcIDTmpls, proxy ); 
            logger.log(Level.FINEST, "lookup successful");


Reply via email to