Author: peter_firmstone
Date: Sun Nov 10 05:45:43 2013
New Revision: 1540447

URL: http://svn.apache.org/r1540447
Log:
Tests failing on arm due to event not arriving before expiry, allow more time 
for events to arrive.

Modified:
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTest.java
    
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTestRenew.td

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTest.java
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTest.java?rev=1540447&r1=1540446&r2=1540447&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTest.java
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTest.java
 Sun Nov 10 05:45:43 2013
@@ -53,6 +53,15 @@ public class UseNotifyLeaseTest extends 
      *
      * <DT>-callbackWait <var>int</var><DD> Number of milliseconds we
      * will wait for the event to fire before giving up.  Defaults to 2000
+     * 
+     * The original test defaulted to 2 seconds waiting for an event 
notification
+     * before giving up, under some circumstances this time period is
+     * insufficient and tests assume the object isn't there.  Most lease 
durations
+     * are 60 seconds, this increase in wait interval doesn't 
+     * appear to be problematic, nor is there anything in the standards that 
suggest
+     * such a short wait period is required.  The additional time will ensure
+     * that network latency and gc events don't cause the test to fail 
incorrectly
+     * assuming the object is no longer available.
      *
      * <DT>-verbose<DD> If set test will print a message before writing
      * an entry into the space
@@ -63,7 +72,7 @@ public class UseNotifyLeaseTest extends 
         super.parse();
         synchronized (this){
             // Get values from property file for this test.
-            callbackWait = 
getConfig().getLongConfigVal("com.sun.jini.test.share.callbackWait", 2000);
+            callbackWait = 
getConfig().getLongConfigVal("com.sun.jini.test.share.callbackWait", 10000);
             verbose = 
getConfig().getBooleanConfigVal("com.sun.jini.test.share.verbose", false);
 
             // Log out test options.

Modified: 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTestRenew.td
URL: 
http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTestRenew.td?rev=1540447&r1=1540446&r2=1540447&view=diff
==============================================================================
--- 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTestRenew.td
 (original)
+++ 
river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/impl/outrigger/leasing/UseNotifyLeaseTestRenew.td
 Sun Nov 10 05:45:43 2013
@@ -4,4 +4,4 @@ include0=../outrigger.properties
 
 com.sun.jini.test.share.exact=true
 com.sun.jini.test.share.renew=2
-com.sun.jini.test.share.callbackWait=4000
\ No newline at end of file
+#com.sun.jini.test.share.callbackWait=10000
\ No newline at end of file


Reply via email to