Author: peter_firmstone Date: Mon Nov 18 21:48:49 2013 New Revision: 1543180
URL: http://svn.apache.org/r1543180 Log: TakeTest05 shares unsynchronized Lists between threads, fix. - Note no related test failures have been observed, it is likely there are no issues as the List state is up to date when each new thread is started, it's just easier to ensure there are no problems by using a thread safe collection. Modified: river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/javaspace/conformance/TakeTest05.java Modified: river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/javaspace/conformance/TakeTest05.java URL: http://svn.apache.org/viewvc/river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/javaspace/conformance/TakeTest05.java?rev=1543180&r1=1543179&r2=1543180&view=diff ============================================================================== --- river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/javaspace/conformance/TakeTest05.java (original) +++ river/jtsk/skunk/qa_refactor/trunk/qa/src/com/sun/jini/test/spec/javaspace/conformance/TakeTest05.java Mon Nov 18 21:48:49 2013 @@ -23,6 +23,7 @@ import java.util.Iterator; import java.util.List; import com.sun.jini.qa.harness.TestException; +import java.util.concurrent.CopyOnWriteArrayList; import net.jini.space.JavaSpace05; import net.jini.core.transaction.Transaction; @@ -36,8 +37,8 @@ public class TakeTest05 extends JavaSpac private final long MAX_ENTRIES = 5; - private ArrayList templates = new ArrayList(); - private ArrayList expectedResult = new ArrayList(); + private List templates = new CopyOnWriteArrayList(); + private List expectedResult = new CopyOnWriteArrayList(); private SimpleEntry sampleEntry1 = new SimpleEntry("TestEntry #1", 1); private SimpleEntry sampleEntry2 = new SimpleEntry("TestEntry #2", 2); @@ -151,8 +152,8 @@ public class TakeTest05 extends JavaSpac reset(); - ArrayList entriesToAdd = new ArrayList(); - ArrayList leasesToAdd = new ArrayList(); + List entriesToAdd = new CopyOnWriteArrayList(); + List leasesToAdd = new CopyOnWriteArrayList(); /* * Taking unavailable entry. @@ -197,8 +198,8 @@ public class TakeTest05 extends JavaSpac instantTime); Thread jsWriterThread2 = new Thread(jsWriter2); - ArrayList entryToAdd = new ArrayList(); - ArrayList leaseToAdd = new ArrayList(); + List entryToAdd = new CopyOnWriteArrayList(); + List leaseToAdd = new CopyOnWriteArrayList(); entryToAdd.add(sampleEntry3); leaseToAdd.add(new Long(leaseForeverTime));
