[ 
https://issues.apache.org/jira/browse/RIVER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152452#comment-17152452
 ] 

Phillip Rhodes commented on RIVER-300:
--------------------------------------

FYI, the patch mentioned above is incomplete. In hindsight, I did not realize 
that the naive way of creating a patch with SVN, via "svn diff > 
filename.patch" did not include newly created directories. And TBH, I still 
don't know how to create a patch with SVN that does that. I've been so immersed 
in the Git world for so long now, I barely remember how to do anything with SVN 
besides "svn up".

 

Anyway, I zipped up the two missing directories and attaching them here. Just 
unzip this in the checked out source directory that has had the above patch 
applied, and that should be everything. Make sure to unzip this from 
$CHECKOUT_DIR/modularize/apache-river/ in order for the files to wind up in the 
right places.

There was also a directory rename that wasn't captured in the original patch. 
To fix this, go to $CHECKOUT_DIR/modularize/apache-river/tools and run:

 

$> mv computehttmdcodebase/ computehttpmdcodebase

 

[^new_modules.zip]

> introduce maven to the river build process
> ------------------------------------------
>
>                 Key: RIVER-300
>                 URL: https://issues.apache.org/jira/browse/RIVER-300
>             Project: River
>          Issue Type: Improvement
>          Components: build
>            Reporter: Jools Enticknap
>            Priority: Major
>         Attachments: apache-river-gradle.zip, apache-river-maven.zip, 
> ldm.pdf, lld.pdf, maven_compilation_working_07042020.diff, new_modules.zip, 
> persistOutrigger.pdf, river-modularization-overview.odt, 
> river-modularization-overview.pdf
>
>
> Currently the river build using ant, but it's a custom build process and has 
> many hang overs from the original make build.
> Given that the project has no 3rd party dependencies, it would be very easy 
> to break the code up into modules.
> Please feel free to add to this JIRA if you have any opinions on how the 
> maven repository should be setup.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to