This is an automated email from the ASF dual-hosted git repository.

yukon pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new e1a42e4  Fix random int bug in SelectMessageQueueByRandom
e1a42e4 is described below

commit e1a42e4ec756245b54026c25ff9f736fbffed1c9
Author: 释一 <[email protected]>
AuthorDate: Fri Dec 1 19:57:52 2017 +0800

    Fix random int bug in SelectMessageQueueByRandom
    
    Author: 释一 <[email protected]>
    
    Closes #173 from swwlqw/master.
---
 ...essageQueueByRandoom.java => SelectMessageQueueByRandom.java} | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandoom.java
 
b/client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandom.java
similarity index 85%
rename from 
client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandoom.java
rename to 
client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandom.java
index 4e9a92d..070fcc3 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandoom.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandom.java
@@ -22,17 +22,12 @@ import 
org.apache.rocketmq.client.producer.MessageQueueSelector;
 import org.apache.rocketmq.common.message.Message;
 import org.apache.rocketmq.common.message.MessageQueue;
 
-public class SelectMessageQueueByRandoom implements MessageQueueSelector {
+public class SelectMessageQueueByRandom implements MessageQueueSelector {
     private Random random = new Random(System.currentTimeMillis());
 
     @Override
     public MessageQueue select(List<MessageQueue> mqs, Message msg, Object 
arg) {
-        int value = random.nextInt();
-        if (value < 0) {
-            value = Math.abs(value);
-        }
-
-        value = value % mqs.size();
+        int value = random.nextInt(mqs.size());
         return mqs.get(value);
     }
 }

-- 
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].

Reply via email to