This is an automated email from the ASF dual-hosted git repository.
yukon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/master by this push:
new c00cf3b Add a modified version of ISSUE_TEMPLATE that created by the
bookkeeper project
c00cf3b is described below
commit c00cf3b2ac933ef655b136b77be891308cdc58de
Author: yukon <yu...@apache.org>
AuthorDate: Mon Mar 5 15:17:59 2018 +0800
Add a modified version of ISSUE_TEMPLATE that created by the bookkeeper
project
---
.github/ISSUE_TEMPLATE.md | 30 ++++++++++++++++++++++++++++++
.github/PULL_REQUEST_TEMPLATE.md | 6 ++++--
2 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
new file mode 100644
index 0000000..9558e29
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE.md
@@ -0,0 +1,30 @@
+The issue tracker is **ONLY** used for bug report and feature request.
+
+Any question or RocketMQ proposal please use our [mailing
lists](http://rocketmq.apache.org/about/contact/).
+
+**BUG REPORT**
+
+1. Please describe the issue you observed:
+
+- What did you do (The steps to reproduce)?
+
+- What did you expect to see?
+
+- What did you see instead?
+
+2. Please tell us about your environment:
+
+3. Other information (e.g. detailed explanation, logs, related issues,
suggestions how to fix, etc):
+
+**FEATURE REQUEST**
+
+1. Please describe the feature you are requesting.
+
+2. Provide any additional detail on your proposed use case for this feature.
+
+2. Indicate the importance of this issue to you (blocker, must-have,
should-have, nice-to-have). Are you currently using any workarounds to address
this issue?
+
+4. If there are some sub-tasks using -[] for each subtask and create a
corresponding issue to map to the sub task:
+- [ ] [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1
description here,
+- [ ] [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2
description here,
+- ...
\ No newline at end of file
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 5d13fff..eb8cb83 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,3 +1,5 @@
+Please do not create a Pull Request without creating an issue first.
+
## What is the purpose of the change
XXXXX
@@ -12,8 +14,8 @@ XXXX
Follow this checklist to help us incorporate your contribution quickly and
easily:
-- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
-- [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
+- [x] Make sure there is a Github issue filed for the change (usually before
you start working on it). Trivial changes like typos do not require a Github
issue. Your pull request should address just this issue, without pulling in
other changes - one PR resolves one issue.
+- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add integration-test in
[test module](https://github.com/apache/rocketmq/tree/master/test).
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
--
To stop receiving notification emails like this one, please contact
yu...@apache.org.
