This is an automated email from the ASF dual-hosted git repository. yukon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-remoting.git
commit f3017bbe58d071736c1f1e765a075422372508b5 Author: yukon <[email protected]> AuthorDate: Thu Jun 6 17:02:03 2019 +0800 Remove logback-classic from benchmark --- benchmarks/remoting-benchmark/pom.xml | 4 ---- .../rocketmq/remoting/impl/netty/NettyRemotingAbstract.java | 8 ++++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/benchmarks/remoting-benchmark/pom.xml b/benchmarks/remoting-benchmark/pom.xml index a18838d..baf3973 100644 --- a/benchmarks/remoting-benchmark/pom.xml +++ b/benchmarks/remoting-benchmark/pom.xml @@ -16,10 +16,6 @@ <groupId>${project.groupId}</groupId> <artifactId>remoting-impl</artifactId> </dependency> - <dependency> - <groupId>ch.qos.logback</groupId> - <artifactId>logback-classic</artifactId> - </dependency> </dependencies> </project> \ No newline at end of file diff --git a/remoting-core/remoting-impl/src/main/java/org/apache/rocketmq/remoting/impl/netty/NettyRemotingAbstract.java b/remoting-core/remoting-impl/src/main/java/org/apache/rocketmq/remoting/impl/netty/NettyRemotingAbstract.java index 62d0d0c..74a39d2 100644 --- a/remoting-core/remoting-impl/src/main/java/org/apache/rocketmq/remoting/impl/netty/NettyRemotingAbstract.java +++ b/remoting-core/remoting-impl/src/main/java/org/apache/rocketmq/remoting/impl/netty/NettyRemotingAbstract.java @@ -228,7 +228,7 @@ public abstract class NettyRemotingAbstract implements RemotingService { try { processorExecutorPair.getRight().submit(run); } catch (RejectedExecutionException e) { - LOG.warn(String.format("Request %s from %s Rejected by server executor %s !", cmd, + LOG.warn(String.format("Request %s from %s is rejected by server executor %s !", cmd, RemotingUtil.extractRemoteAddress(ctx.channel()), processorExecutorPair.getRight().toString())); if (cmd.trafficType() != TrafficType.REQUEST_ONEWAY) { @@ -302,7 +302,7 @@ public abstract class NettyRemotingAbstract implements RemotingService { try { responseFuture.executeAsyncHandler(); } catch (Throwable e) { - LOG.warn("execute callback in executor exception, and callback throw", e); + LOG.warn("Execute async handler in specific executor exception, ", e); } finally { responseFuture.release(); } @@ -310,7 +310,7 @@ public abstract class NettyRemotingAbstract implements RemotingService { }); } catch (Throwable e) { runInThisThread = true; - LOG.warn("execute callback in executor exception, maybe executor busy", e); + LOG.warn("Execute async handler in executor exception, maybe the executor is busy now", e); } } else { runInThisThread = true; @@ -320,7 +320,7 @@ public abstract class NettyRemotingAbstract implements RemotingService { try { responseFuture.executeAsyncHandler(); } catch (Throwable e) { - LOG.warn("executeInvokeCallback Exception", e); + LOG.warn("Execute async handler in current thread exception", e); } finally { responseFuture.release(); }
