This is an automated email from the ASF dual-hosted git repository.
dinglei pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 30ad172 [ISSUE #1741] Rename takeMessags to takeMessages
30ad172 is described below
commit 30ad172331a56b67a33b9ee466e300d2acd0586b
Author: xujianhai666 <[email protected]>
AuthorDate: Mon Mar 30 16:44:58 2020 +0800
[ISSUE #1741] Rename takeMessags to takeMessages
Closes #1741
---
.../client/impl/consumer/ConsumeMessageOrderlyService.java | 2 +-
.../org/apache/rocketmq/client/impl/consumer/ProcessQueue.java | 2 +-
.../apache/rocketmq/client/impl/consumer/ProcessQueueTest.java | 10 +++++-----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java
index e440bd9..f65567b 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java
@@ -452,7 +452,7 @@ public class ConsumeMessageOrderlyService implements
ConsumeMessageService {
final int consumeBatchSize =
ConsumeMessageOrderlyService.this.defaultMQPushConsumer.getConsumeMessageBatchMaxSize();
- List<MessageExt> msgs =
this.processQueue.takeMessags(consumeBatchSize);
+ List<MessageExt> msgs =
this.processQueue.takeMessages(consumeBatchSize);
defaultMQPushConsumerImpl.resetRetryAndNamespace(msgs,
defaultMQPushConsumer.getConsumerGroup());
if (!msgs.isEmpty()) {
final ConsumeOrderlyContext context = new
ConsumeOrderlyContext(this.messageQueue);
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java
index 092da9a..f659bd3 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java
@@ -296,7 +296,7 @@ public class ProcessQueue {
}
}
- public List<MessageExt> takeMessags(final int batchSize) {
+ public List<MessageExt> takeMessages(final int batchSize) {
List<MessageExt> result = new ArrayList<MessageExt>(batchSize);
final long now = System.currentTimeMillis();
try {
diff --git
a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java
b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java
index d6a6dcf..16e4a0d 100644
---
a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java
+++
b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java
@@ -38,7 +38,7 @@ public class ProcessQueueTest {
assertThat(pq.getMsgCount().get()).isEqualTo(100);
- pq.takeMessags(10);
+ pq.takeMessages(10);
pq.commit();
assertThat(pq.getMsgCount().get()).isEqualTo(90);
@@ -55,7 +55,7 @@ public class ProcessQueueTest {
assertThat(pq.getMsgSize().get()).isEqualTo(100 * 123);
- pq.takeMessags(10);
+ pq.takeMessages(10);
pq.commit();
assertThat(pq.getMsgSize().get()).isEqualTo(90 * 123);
@@ -74,17 +74,17 @@ public class ProcessQueueTest {
assertThat(processQueueInfo.getCachedMsgSizeInMiB()).isEqualTo(12);
- pq.takeMessags(10000);
+ pq.takeMessages(10000);
pq.commit();
pq.fillProcessQueueInfo(processQueueInfo);
assertThat(processQueueInfo.getCachedMsgSizeInMiB()).isEqualTo(10);
- pq.takeMessags(10000);
+ pq.takeMessages(10000);
pq.commit();
pq.fillProcessQueueInfo(processQueueInfo);
assertThat(processQueueInfo.getCachedMsgSizeInMiB()).isEqualTo(9);
- pq.takeMessags(80000);
+ pq.takeMessages(80000);
pq.commit();
pq.fillProcessQueueInfo(processQueueInfo);
assertThat(processQueueInfo.getCachedMsgSizeInMiB()).isEqualTo(0);