[rocketmq] branch develop updated: [ISSUE #3109]Return a no-support value when not match any request code

[vongosling]

This is an automated email from the ASF dual-hosted git repository.

vongosling pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 9a5ec90  [ISSUE  #3109]Return a no-support value when not match any 
request code
9a5ec90 is described below

commit 9a5ec9082f6611629fc6c7459e32ac606a893c4d
Author: lizhiboo <lizhi...@yeah.net>
AuthorDate: Thu Jul 1 15:00:27 2021 +0800

    [ISSUE  #3109]Return a no-support value when not match any request code
---
 .../rocketmq/broker/processor/AdminBrokerProcessor.java      | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git 
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
index 0a1d214..97ca51d 100644
--- 
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
+++ 
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
@@ -116,6 +116,7 @@ import 
org.apache.rocketmq.remoting.netty.NettyRequestProcessor;
 import org.apache.rocketmq.remoting.protocol.LanguageCode;
 import org.apache.rocketmq.remoting.protocol.RemotingCommand;
 import org.apache.rocketmq.remoting.protocol.RemotingSerializable;
+import org.apache.rocketmq.remoting.protocol.RemotingSysResponseCode;
 import org.apache.rocketmq.store.ConsumeQueue;
 import org.apache.rocketmq.store.ConsumeQueueExt;
 import org.apache.rocketmq.store.DefaultMessageStore;
@@ -235,10 +236,8 @@ public class AdminBrokerProcessor extends 
AsyncNettyRequestProcessor implements
             case RequestCode.GET_BROKER_CLUSTER_ACL_CONFIG:
                 return getBrokerClusterAclConfig(ctx, request);
             default:
-                break;
+                return getUnknownCmdResponse(ctx, request);
         }
-
-        return null;
     }
 
     @Override
@@ -459,6 +458,13 @@ public class AdminBrokerProcessor extends 
AsyncNettyRequestProcessor implements
         return null;
     }
 
+    private RemotingCommand getUnknownCmdResponse(ChannelHandlerContext ctx, 
RemotingCommand request) {
+        String error = " request type " + request.getCode() + " not supported";
+        final RemotingCommand response =
+                
RemotingCommand.createResponseCommand(RemotingSysResponseCode.REQUEST_CODE_NOT_SUPPORTED,
 error);
+        return response;
+    }
+
     private RemotingCommand getAllTopicConfig(ChannelHandlerContext ctx, 
RemotingCommand request) {
         final RemotingCommand response = 
RemotingCommand.createResponseCommand(GetAllTopicConfigResponseHeader.class);
         // final GetAllTopicConfigResponseHeader responseHeader =