This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new c121565 [ISSUE #4040] Unnecessary toString methods deleted (#4041)
c121565 is described below
commit c121565c3eb59d536edc54512624e420136d30e5
Author: hjl11 <[email protected]>
AuthorDate: Mon Mar 28 10:15:43 2022 +0800
[ISSUE #4040] Unnecessary toString methods deleted (#4041)
---
.../rocketmq/broker/processor/AbstractSendMessageProcessor.java | 2 +-
.../client/impl/consumer/ConsumeMessageConcurrentlyService.java | 2 +-
.../apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java | 2 +-
filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java | 4 ++--
.../java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java | 2 +-
.../main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java | 4 ++--
.../rocketmq/tools/command/message/PrintMessageByQueueCommand.java | 2 +-
7 files changed, 9 insertions(+), 9 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java
index 3303d70..f0925a7 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AbstractSendMessageProcessor.java
@@ -221,7 +221,7 @@ public abstract class AbstractSendMessageProcessor extends
AsyncNettyRequestProc
if (queueIdInt >= idValid) {
String errorInfo = String.format("request queueId[%d] is illegal,
%s Producer: %s",
queueIdInt,
- topicConfig.toString(),
+ topicConfig,
RemotingHelper.parseChannelRemoteAddr(ctx.channel()));
log.warn(errorInfo);
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
index a1e4eed..c3626c3 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
@@ -314,7 +314,7 @@ public class ConsumeMessageConcurrentlyService implements
ConsumeMessageService
this.defaultMQPushConsumerImpl.sendMessageBack(msg, delayLevel,
context.getMessageQueue().getBrokerName());
return true;
} catch (Exception e) {
- log.error("sendMessageBack exception, group: " +
this.consumerGroup + " msg: " + msg.toString(), e);
+ log.error("sendMessageBack exception, group: " +
this.consumerGroup + " msg: " + msg, e);
}
return false;
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
index ea80478..7356936 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -399,7 +399,7 @@ public class DefaultMQProducerImpl implements
MQProducerInner {
if (info != null && topic != null) {
TopicPublishInfo prev = this.topicPublishInfoTable.put(topic,
info);
if (prev != null) {
- log.info("updateTopicPublishInfo prev is not null, " +
prev.toString());
+ log.info("updateTopicPublishInfo prev is not null, " + prev);
}
}
}
diff --git
a/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java
b/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java
index 9a3de60..a1cbd24 100644
--- a/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java
+++ b/filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java
@@ -145,7 +145,7 @@ public class BloomFilter {
if (!isValid(filterData)) {
throw new IllegalArgumentException(
String.format("Bloom filter data may not belong to this
filter! %s, %s",
- filterData, this.toString())
+ filterData, this)
);
}
hashTo(filterData.getBitPos(), bits);
@@ -183,7 +183,7 @@ public class BloomFilter {
if (!isValid(filterData)) {
throw new IllegalArgumentException(
String.format("Bloom filter data may not belong to this
filter! %s, %s",
- filterData, this.toString())
+ filterData, this)
);
}
return isHit(filterData.getBitPos(), bits);
diff --git
a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
index 5ced3b7..8576b23 100644
---
a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
+++
b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
@@ -513,7 +513,7 @@ public class NettyRemotingClient extends
NettyRemotingAbstract implements Remoti
log.info("createChannel: connect remote host[{}] success,
{}", addr, channelFuture.toString());
return cw.getChannel();
} else {
- log.warn("createChannel: connect remote host[" + addr + "]
failed, " + channelFuture.toString(), channelFuture.cause());
+ log.warn("createChannel: connect remote host[" + addr + "]
failed, " + channelFuture, channelFuture.cause());
}
} else {
log.warn("createChannel: connect remote host[{}] timeout {}ms,
{}", addr, this.nettyClientConfig.getConnectTimeoutMillis(),
diff --git
a/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java
b/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java
index 8bd93b6..c90c5c9 100644
--- a/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java
+++ b/test/src/main/java/org/apache/rocketmq/test/util/DuplicateMessageInfo.java
@@ -90,7 +90,7 @@ public class DuplicateMessageInfo<T> {
getFloatNumString(msgQueueInnerDupRate) + "%\r\n");
}
- System.out.print(strBuilder.toString());
+ System.out.print(strBuilder);
String titleString = "queue\tdupQueue\tdupMsg\r\n";
System.out.print(titleString);
@@ -104,7 +104,7 @@ public class DuplicateMessageInfo<T> {
String strToWrite;
byte[] byteToWrite;
- strToWrite = strBuilder.toString() + titleString;
+ strToWrite = strBuilder + titleString;
for (int i = 0; i < msgListSize; i++)
strToWrite += strBQueue.get(i).toString() + "\r\n";
diff --git
a/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java
b/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java
index 46c5f74..88f1b74 100644
---
a/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java
+++
b/tools/src/main/java/org/apache/rocketmq/tools/command/message/PrintMessageByQueueCommand.java
@@ -93,7 +93,7 @@ public class PrintMessageByQueueCommand implements SubCommand
{
for (MessageExt msg : msgs) {
try {
- System.out.printf("MSGID: %s %s BODY: %s%n", msg.getMsgId(),
msg.toString(),
+ System.out.printf("MSGID: %s %s BODY: %s%n", msg.getMsgId(),
msg,
printBody ? new String(msg.getBody(), charsetName) : "NOT
PRINT BODY");
} catch (UnsupportedEncodingException e) {
e.printStackTrace();
