This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 96fd4f52e [ISSUE #4851] Fix HAService implement class some method miss 
@Override annotation (#4852)
96fd4f52e is described below

commit 96fd4f52e09536e2e8487c701cc7846b0529b04e
Author: mxsm <[email protected]>
AuthorDate: Sun Aug 21 09:57:00 2022 +0800

    [ISSUE #4851] Fix HAService implement class some method miss @Override 
annotation (#4852)
---
 .../java/org/apache/rocketmq/store/ha/DefaultHAService.java   | 11 +++++++++++
 .../rocketmq/store/ha/autoswitch/AutoSwitchHAService.java     |  1 +
 2 files changed, 12 insertions(+)

diff --git 
a/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java 
b/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java
index 538cc5697..aa307a0af 100644
--- a/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java
+++ b/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java
@@ -63,6 +63,7 @@ public class DefaultHAService implements HAService {
     public DefaultHAService() {
     }
 
+    @Override
     public void init(final DefaultMessageStore defaultMessageStore) throws 
IOException {
         this.defaultMessageStore = defaultMessageStore;
         this.acceptSocketService =
@@ -74,22 +75,26 @@ public class DefaultHAService implements HAService {
         this.haConnectionStateNotificationService = new 
HAConnectionStateNotificationService(this, defaultMessageStore);
     }
 
+    @Override
     public void updateMasterAddress(final String newAddr) {
         if (this.haClient != null) {
             this.haClient.updateMasterAddress(newAddr);
         }
     }
 
+    @Override
     public void updateHaMasterAddress(String newAddr) {
         if (this.haClient != null) {
             this.haClient.updateHaMasterAddress(newAddr);
         }
     }
 
+    @Override
     public void putRequest(final CommitLog.GroupCommitRequest request) {
         this.groupTransferService.putRequest(request);
     }
 
+    @Override
     public boolean isSlaveOK(final long masterPutWhere) {
         boolean result = this.connectionCount.get() > 0;
         result =
@@ -111,10 +116,12 @@ public class DefaultHAService implements HAService {
         }
     }
 
+    @Override
     public AtomicInteger getConnectionCount() {
         return connectionCount;
     }
 
+    @Override
     public void start() throws Exception {
         this.acceptSocketService.beginAccept();
         this.acceptSocketService.start();
@@ -138,6 +145,7 @@ public class DefaultHAService implements HAService {
         }
     }
 
+    @Override
     public void shutdown() {
         if (this.haClient != null) {
             this.haClient.shutdown();
@@ -162,14 +170,17 @@ public class DefaultHAService implements HAService {
         return defaultMessageStore;
     }
 
+    @Override
     public WaitNotifyObject getWaitNotifyObject() {
         return waitNotifyObject;
     }
 
+    @Override
     public AtomicLong getPush2SlaveMaxOffset() {
         return push2SlaveMaxOffset;
     }
 
+    @Override
     public int inSyncReplicasNums(final long masterPutWhere) {
         int inSyncNums = 1;
         for (HAConnection conn : this.connectionList) {
diff --git 
a/store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
 
b/store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
index 0814e24ef..2f9e93c06 100644
--- 
a/store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
+++ 
b/store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
@@ -262,6 +262,7 @@ public class AutoSwitchHAService extends DefaultHAService {
         }
     }
 
+    @Override
     public int inSyncReplicasNums(final long masterPutWhere) {
         return syncStateSet.size();
     }

Reply via email to