This is an automated email from the ASF dual-hosted git repository.
aaronai pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 32c7d37f4 [ISSUE #5205]Enable checkstyle for test code
(rocketmq-logging) (#5258)
32c7d37f4 is described below
commit 32c7d37f488ef3ba78e2318e1535717d5efb1f7b
Author: Ekin <[email protected]>
AuthorDate: Mon Oct 10 10:05:49 2022 +0800
[ISSUE #5205]Enable checkstyle for test code (rocketmq-logging) (#5258)
---
logging/pom.xml | 28 +++++++++++++++++++++-
.../rocketmq/logging/InnerLoggerFactoryTest.java | 1 -
.../rocketmq/logging/inner/AppenderTest.java | 2 --
.../apache/rocketmq/logging/inner/LayoutTest.java | 2 --
.../apache/rocketmq/logging/inner/LevelTest.java | 4 ++--
.../apache/rocketmq/logging/inner/LoggerTest.java | 4 ----
.../logging/inner/MessageFormatterTest.java | 3 +--
7 files changed, 30 insertions(+), 14 deletions(-)
diff --git a/logging/pom.xml b/logging/pom.xml
index 667fdef68..3cca56856 100644
--- a/logging/pom.xml
+++ b/logging/pom.xml
@@ -15,7 +15,8 @@
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
<parent>
<groupId>org.apache.rocketmq</groupId>
<artifactId>rocketmq-all</artifactId>
@@ -44,4 +45,29 @@
</dependency>
</dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${maven-checkstyle-plugin.version}</version>
+ <executions>
+ <execution>
+ <id>validate</id>
+ <phase>validate</phase>
+ <configuration>
+
<configLocation>${project.parent.basedir}/style/rmq_checkstyle.xml</configLocation>
+ <inputEncoding>UTF-8</inputEncoding>
+ <consoleOutput>true</consoleOutput>
+ <failsOnError>true</failsOnError>
+
<includeTestSourceDirectory>true</includeTestSourceDirectory>
+ </configuration>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
</project>
\ No newline at end of file
diff --git
a/logging/src/test/java/org/apache/rocketmq/logging/InnerLoggerFactoryTest.java
b/logging/src/test/java/org/apache/rocketmq/logging/InnerLoggerFactoryTest.java
index c47dba684..2faaabcd6 100644
---
a/logging/src/test/java/org/apache/rocketmq/logging/InnerLoggerFactoryTest.java
+++
b/logging/src/test/java/org/apache/rocketmq/logging/InnerLoggerFactoryTest.java
@@ -82,7 +82,6 @@ public class InnerLoggerFactoryTest extends BasicLoggerTest {
logger3.debug("debug {}", "hahahah");
String content = new String(byteArrayOutputStream.toByteArray());
- System.out.println(content);
Assert.assertTrue(content.contains("InnerLoggerFactoryTest"));
Assert.assertTrue(content.contains("info"));
diff --git
a/logging/src/test/java/org/apache/rocketmq/logging/inner/AppenderTest.java
b/logging/src/test/java/org/apache/rocketmq/logging/inner/AppenderTest.java
index 37ff8bd47..cd3d0aa8a 100644
--- a/logging/src/test/java/org/apache/rocketmq/logging/inner/AppenderTest.java
+++ b/logging/src/test/java/org/apache/rocketmq/logging/inner/AppenderTest.java
@@ -91,8 +91,6 @@ public class AppenderTest extends BasicLoggerTest {
String content = readFile(file);
- System.out.println(content);
-
Assert.assertTrue(content.contains("info"));
Assert.assertTrue(content.contains("RuntimeException"));
Assert.assertTrue(!content.contains("debug"));
diff --git
a/logging/src/test/java/org/apache/rocketmq/logging/inner/LayoutTest.java
b/logging/src/test/java/org/apache/rocketmq/logging/inner/LayoutTest.java
index 66ef18eae..c48be1d82 100644
--- a/logging/src/test/java/org/apache/rocketmq/logging/inner/LayoutTest.java
+++ b/logging/src/test/java/org/apache/rocketmq/logging/inner/LayoutTest.java
@@ -48,7 +48,5 @@ public class LayoutTest extends BasicLoggerTest {
LoggingEvent loggingEvent = new LoggingEvent(Logger.class.getName(),
logger, org.apache.rocketmq.logging.inner.Level.INFO,
"junit test error", null);
String format = innerLayout.format(loggingEvent);
-
- System.out.println(format);
}
}
diff --git
a/logging/src/test/java/org/apache/rocketmq/logging/inner/LevelTest.java
b/logging/src/test/java/org/apache/rocketmq/logging/inner/LevelTest.java
index 21667e148..297523a74 100644
--- a/logging/src/test/java/org/apache/rocketmq/logging/inner/LevelTest.java
+++ b/logging/src/test/java/org/apache/rocketmq/logging/inner/LevelTest.java
@@ -30,8 +30,8 @@ public class LevelTest {
}
@Test
- public void loggerLevel(){
+ public void loggerLevel() {
Level level = Logger.getRootLogger().getLevel();
- Assert.assertTrue(level!=null);
+ Assert.assertTrue(level != null);
}
}
diff --git
a/logging/src/test/java/org/apache/rocketmq/logging/inner/LoggerTest.java
b/logging/src/test/java/org/apache/rocketmq/logging/inner/LoggerTest.java
index 4e738e230..904c63200 100644
--- a/logging/src/test/java/org/apache/rocketmq/logging/inner/LoggerTest.java
+++ b/logging/src/test/java/org/apache/rocketmq/logging/inner/LoggerTest.java
@@ -66,8 +66,6 @@ public class LoggerTest extends BasicLoggerTest {
String result = new String(byteArrayOutputStream.toByteArray());
- System.out.println(result);
-
Assert.assertTrue(result.contains("info"));
Assert.assertTrue(result.contains("RuntimeException"));
Assert.assertTrue(result.contains("WATERMARK"));
@@ -101,8 +99,6 @@ public class LoggerTest extends BasicLoggerTest {
String content = readFile(file);
- System.out.println(content);
-
Assert.assertTrue(content.contains("info"));
Assert.assertTrue(content.contains("RuntimeException"));
Assert.assertTrue(!content.contains("debug"));
diff --git
a/logging/src/test/java/org/apache/rocketmq/logging/inner/MessageFormatterTest.java
b/logging/src/test/java/org/apache/rocketmq/logging/inner/MessageFormatterTest.java
index 5fa80ad56..5d3d86802 100644
---
a/logging/src/test/java/org/apache/rocketmq/logging/inner/MessageFormatterTest.java
+++
b/logging/src/test/java/org/apache/rocketmq/logging/inner/MessageFormatterTest.java
@@ -25,7 +25,7 @@ import org.junit.Test;
public class MessageFormatterTest {
@Test
- public void formatTest(){
+ public void formatTest() {
InnerLoggerFactory.FormattingTuple logging =
InnerLoggerFactory.MessageFormatter.format("this is {},and {}", "logging",
6546);
String message = logging.getMessage();
Assert.assertTrue(message.contains("logging"));
@@ -33,7 +33,6 @@ public class MessageFormatterTest {
InnerLoggerFactory.FormattingTuple format =
InnerLoggerFactory.MessageFormatter.format("cause exception {}", 143545, new
RuntimeException());
String message1 = format.getMessage();
Throwable throwable = format.getThrowable();
- System.out.println(message1);
Assert.assertTrue(throwable != null);
}
