[GitHub] [rocketmq] thezp opened a new issue, #5372: is this necessary to call fileWatchService's shutdown method twice?

[GitBox]

thezp opened a new issue, #5372:
URL: https://github.com/apache/rocketmq/issues/5372

   there are two places in BrokerController.java that fileWatchService's 
shutdown method is called :
   line 1276:1278
   <img width="427" alt="image" 
src="https://user-images.githubusercontent.com/7849032/196996621-54a7fd5b-ad3c-4f8b-a398-ebf5c3e86973.png";>
   and line 1357:1359
   <img width="423" alt="image" 
src="https://user-images.githubusercontent.com/7849032/196996798-f8b82c77-482b-43df-85dd-36c5794a2d18.png";>
   i think the second call is unnecessary because the second call will do 
nothing as variable started is false in ServiceThread
   <img width="932" alt="image" 
src="https://user-images.githubusercontent.com/7849032/197003701-a571e2b4-84be-469a-8997-a25c02be5cdb.png";>
   so we can delete line 1357:1359 safely
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org