ShadowySpirits commented on code in PR #5357:
URL: https://github.com/apache/rocketmq/pull/5357#discussion_r1001326715
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -1517,8 +1517,12 @@ private RemotingCommand
getConsumeStats(ChannelHandlerContext ctx,
}
}
+ long pullOffset =
this.brokerController.getConsumerOffsetManager().queryPullOffset(
+ requestHeader.getConsumerGroup(), topic, i);
+
offsetWrapper.setBrokerOffset(brokerOffset);
offsetWrapper.setConsumerOffset(consumerOffset);
+ offsetWrapper.setPullOffset(pullOffset >= 0 ? pullOffset : 0);
Review Comment:
It needs to check if pullOffset is bigger than consumerOffset. Otherwise,
inflight will be negative when the user resets offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
