github-code-scanning[bot] commented on code in PR #951:
URL:
https://github.com/apache/rocketmq-client-go/pull/951#discussion_r1002459723
##########
internal/remote/tcp_conn.go:
##########
@@ -34,11 +35,23 @@
func initConn(ctx context.Context, addr string, config *RemotingClientConfig)
(*tcpConnWrapper, error) {
var d net.Dialer
-
d.KeepAlive = config.KeepAliveDuration
d.Deadline = time.Now().Add(config.ConnectionTimeout)
- conn, err := d.DialContext(ctx, "tcp", addr)
+ var conn net.Conn
+ var err error
+ if config.UseTls {
+ tlsDialer := tls.Dialer{
+ NetDialer: &d,
+ Config: &tls.Config{
+ InsecureSkipVerify: true,
Review Comment:
## Disabled TLS certificate check
InsecureSkipVerify should not be used in production code.
[Show more
details](https://github.com/apache/rocketmq-client-go/security/code-scanning/5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
