yiduwangkai commented on code in PR #46:
URL: https://github.com/apache/rocketmq-flink/pull/46#discussion_r1003972794
##########
src/main/java/org/apache/rocketmq/flink/source/reader/RocketMQPartitionSplitReader.java:
##########
@@ -173,25 +177,28 @@ public RecordsWithSplitIds<Tuple3<T, Long, Long>> fetch()
throws IOException {
recordsBySplits.prepareForRead();
return recordsBySplits;
}
- if (StringUtils.isNotEmpty(sql)) {
- pullResult =
- consumer.pull(
- messageQueue,
- MessageSelector.bySql(sql),
- messageOffset,
- MAX_MESSAGE_NUMBER_PER_BLOCK);
- } else {
- pullResult =
- consumer.pull(
- messageQueue,
- tag,
- messageOffset,
- MAX_MESSAGE_NUMBER_PER_BLOCK);
- }
- } catch (MQClientException
- | RemotingException
- | MQBrokerException
- | InterruptedException e) {
+ consumer.assign(Collections.singletonList(messageQueue));
Review Comment:
actually, seek method is enough，i will remove assign code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
