lizhanhui commented on code in PR #5407:
URL: https://github.com/apache/rocketmq/pull/5407#discussion_r1006505619
##########
broker/src/main/java/org/apache/rocketmq/broker/metrics/BrokerMetricsManager.java:
##########
@@ -108,26 +113,26 @@ private boolean checkConfig() {
private void init() {
if (!checkConfig()) {
- LOGGER.error("check broker metrics config failed, will not export
metrics");
+ LOGGER.error("check metrics config failed, will not export
metrics");
return;
}
- String labels = brokerConfig.getBrokerMetricsLabel();
+ String labels = brokerConfig.getMetricsLabel();
if (StringUtils.isNotBlank(labels)) {
List<String> kvPairs =
Splitter.on(',').omitEmptyStrings().splitToList(labels);
for (String item : kvPairs) {
String[] split = item.split(":");
if (split.length != 2) {
- LOGGER.warn("brokerMetricsLabel is not valid: {}",
brokerConfig.getBrokerMetricsLabel());
+ LOGGER.warn("metricsLabel is not valid: {}",
brokerConfig.getMetricsLabel());
continue;
}
LABEL_MAP.put(split[0], split[1]);
}
}
- if (brokerConfig.isBrokerMetricsPreferDelta()) {
+ if (brokerConfig.isMetricsPreferDelta()) {
Review Comment:
isMetricsPreferDelta --> isDeltaMetricPerferred
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
