echooymxq commented on code in PR #5419:
URL: https://github.com/apache/rocketmq/pull/5419#discussion_r1009080212
##########
remoting/src/test/java/org/apache/rocketmq/remoting/TlsTest.java:
##########
@@ -152,7 +153,9 @@ else if
("noClientAuthFailure".equals(name.getMethodName())) {
remotingServer = RemotingServerTest.createRemotingServer();
remotingClient = RemotingServerTest.createRemotingClient(clientConfig);
- await().atMost(200, TimeUnit.MILLISECONDS).until(() ->
isHostConnectable(getServerAddress()));
+ await()
+ .pollDelay(Duration.ZERO)
Review Comment:
@lizhanhui Hi, zhanhui. Thank your review it, as your say, here is use
defaultPollInterval and it fixed poll interval, so it same poll delay as poll
interval , it will sleep 100ms first and execute it. so the 200ms of tests
offen cause timeout. The easiest way is to set it to 500ms, but i think there
no need to wait it, because netty server channel bind is sync and tested work
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
