lizhimins opened a new issue, #143:
URL: https://github.com/apache/rocketmq-flink/issues/143

   Three gaps in `docs/` that make the connector hard to use correctly.
   
   **The SQL row format is undocumented.** The source maps a message body onto 
a row by splitting the body into lines and then each line into fields, the 
field delimiter defaults to `\u0001`, and a row whose field count does not 
match the column count is dropped according to 
`rocketmq.client.message.length.check`. None of this is written down, and there 
is no `format` option, so a JSON or CSV body silently produces zero rows. The 
format options, the accepted length check values, and the two cases where a 
column is filled from a message property instead of the body all need 
documenting.
   
   **The source metrics are undocumented**, including how to read them: a 
positive `records-lag` with nothing being emitted is how a consumer group the 
broker does not deliver to shows up.
   
   **The gRPC docs describe LITE mode as a wildcard subscription on the main 
topic.** The subscription is the list of sub lite topics, and a main topic 
bound without it receives nothing. `rocketmq.source.sub-lite-topics` is missing 
from the option table entirely.
   
   Some option documentation is also wrong: `rocketmq.source.startup.scan.mode` 
lists `group` and `specific`, which the code does not accept, and 
`rocketmq.source.offset.commit.auto` is documented as defaulting to true.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to