lizhimins opened a new pull request, #147:
URL: https://github.com/apache/rocketmq-flink/pull/147

   [ISSUE #143] docs: document the row format, the source metrics and the lite 
topic list
   
   The SQL row format was undocumented, which is how a source that reads zero 
rows
   stays undiagnosed: the body is split into lines and then into fields, the 
field
   delimiter defaults to \u0001, and a row whose field count does not match the
   column count is dropped. List the format options, the length check values and
   the two cases where a column comes from a message property instead of the 
body,
   and say plainly that there is no format option.
   
   Add the source metrics, including that a positive records-lag with nothing 
being
   emitted is how an unregistered consumer group shows up.
   
   Correct the scan modes to the ones the code accepts, the offset.commit.auto
   default to false, and the note about client side filtering: SQL92 is 
evaluated
   with the broker's own filter implementation, so only the network traffic 
differs
   from server side filtering.
   
   The gRPC docs described LITE mode as a wildcard subscription on the main 
topic.
   The subscription is the list of sub lite topics, and a main topic bound 
without
   it receives nothing, so document rocketmq.source.sub-lite-topics as required 
and
   note that the list is also the isolation boundary.
   
   Record that the legacy source assigns the queues Flink allocated to the 
subtask,
   and that an async send failure now fails the task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to