lizhimins opened a new pull request, #7356:
URL: https://github.com/apache/rocketmq-dashboard/pull/7356
### Which Issue(s) This PR Fixes
No tracking issue. Repairs the trunk state left by merging #7311 and #7312.
### Brief Description
Both changes were correct on their own branch and only break together, which
is why a
full-suite run on the merged trunk is what caught them:
- `UserManagement.tsx` still called `setSessionDrawerUser(null)` in the
delete-user and
revoke-all-sessions paths. The drawer-to-modal round renamed that setter to
`setSessionModalUser`, so `tsc -b` — the frontend build gate — failed on
the merged trunk
while each side compiled alone.
- `UserManagementModalValidation.test.tsx` mocks `api/studioUsers` with an
explicit factory,
and the account lifecycle added five functions to that module
(`deleteStudioUser`,
`listStudioLoginLockouts`, `revokeAllStudioUserSessions`,
`revokeStudioSession`,
`setStudioUserRole`). The page awaits `listStudioLoginLockouts()` inside a
`Promise.all`, so
the missing mock returned `undefined`, `.catch` threw, the whole load
rejected and the table
rendered no rows — the case then could not find the `Password` action it
clicks. The mock now
covers all five, with the lockouts call resolving to `[]` instead of
returning undefined.
### How Did You Test This Change?
```
cd web && npm run lint && npm test && npm run build
npm run lint -> 0 errors (10 pre-existing warnings, none in these files)
npm test -> Test Files 164 passed (164), Tests 1908 passed (1908)
npm run build -> built in 14.32s, license check passed (134 components, 141
license files)
cd server && mvn -B -ntp test
Tests run: 4055, Failures: 0, Errors: 0, Skipped: 0 -> BUILD SUCCESS
(MySQL 8.0 with db/schema.sql loaded, mirroring the CI backend-test job)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
(no new text)
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [x] New source files carry the ASF license header (no new files)
- [x] Documentation touched where behaviour changed (no behaviour change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
