lizhimins opened a new pull request, #7357:
URL: https://github.com/apache/rocketmq-dashboard/pull/7357
### Which Issue(s) This PR Fixes
No tracking issue. Cleans up what #5895 left on the trunk.
### Brief Description
Two follow-ups to #5895 (merged as `9d22a2729`):
- **The merge carried a committed symlink** at `web/node_modules` pointing
at the author's own
worktree (`/home/xiaoyang/rmq-worktrees/pr5926/web/node_modules`). Any
checkout on another
machine gets a dangling link exactly where the package tree must live —
this branch's own CI
checkout did, and every frontend job would fail to resolve `vite`. The
directory is gitignored
for precisely this reason; remove the symlink from the index.
- **The sibling export still swallows the server reason.** #5895 gave the
audit export the
`describeApiError` treatment; the cloud credential export in
`CloudCredentialTab.tsx` has the
same shape — a refused export (for example above a server record cap)
answers with a named
reason and the only actionable step, and the handler dropped it for the
generic retry advice.
Same extractor, same fallback string, plus a case pinning the server
message in the toast.
### How Did You Test This Change?
```
cd web && npx vitest run
src/pages/settings/__tests__/CloudCredentialTab.test.tsx \
src/pages/ops/__tests__/AuditPage.test.tsx
```
(the new case fails against the old `catch {}` and passes with
`describeApiError`; the symlink
removal is verified by `git ls-tree` no longer listing `web/node_modules`)
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
(no new text)
- [x] Architecture constraints stay green (no backend change)
- [x] New source files carry the ASF license header (no new files)
- [x] Documentation touched where behaviour changed (no doc change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
