The GitHub Actions job "Run Integration Tests" on rocketmq.git/develop has 
succeeded.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
23aaa3e7cbe086b89a82aa20e95b87b27fc36ccf / bai mengxuan <[email protected]>
fix(tools): stop trimming the ACL password in mqadmin create/updateUser (#11447)

The secret is a payload, not a name: the broker stores the secret verbatim and 
derives the
client's credentials from it, so a passphrase with leading or trailing 
whitespace is legal -
and pasted secrets routinely carry one. CreateUserSubCommand and 
UpdateUserSubCommand ran it
through StringUtils.trim before the call, which stores a secret the operator 
never typed:
every client that presents the real secret is then rejected with no hint about 
the
difference. The sendMessage body carried the same shape until #11414.

Drop the trim on the password only - the username, user type and address keep 
theirs - and
give both commands the createAdminExt seam CopyUsersSubCommand already exposes, 
so the
behaviour is pinned by a test.

Report URL: https://github.com/apache/rocketmq/actions/runs/40282380468

With regards,
GitHub Actions via GitBox

Reply via email to