lizhimins commented on PR #5725: URL: https://github.com/apache/rocketmq-dashboard/pull/5725#issuecomment-6435160725
Closing this one: the trunk has since removed the field this PR populates, deliberately. When this was reviewed the mapping fix was correct and complete - `LiteTopicSessionOutput.from` already forwarded `vo.getPopProgress()`, so the one line restored the value for the REST endpoint, the `rmq.litetopic.session` tool and the page's "Pop 进度" section at once, with a null-when-unknown guard instead of a fabricated 0%. Since then #6144 (`0e60ee54e`, "stop presenting unread or partial values as measured") removed `popProgress` end to end: the `LiteTopicSessionVO` field, the `LiteTopicSession` model field and its nested `PopConsumeProgress` shape, the AI contract component and its `litetopic.yaml` / `catalog_gen.go` entry, the TypeScript contract and the `liteTopic.popProgress` translation. The reason is in `LiteTopicSession`: the session scan is capped, so `consumedMessages` and `totalMessages` are **lower bounds** rather than totals once `consumedScanTruncated` is set - and a percentage derived from them presents a partial value as a measured one. This PR's guard checks the counters but not the truncation flag, which did not exist at its baseline, so landing it as-is would reintroduce exactly that. Merging it now would mean re-adding the whole chain and partially reverting #6144, which is a product decision rather than a rebase. If the Pop progress panel is wanted back, the right shape is a fresh change that returns an absent value whenever `consumedScanTruncated` is true, so the panel hides instead of showing a percentage computed from a lower bound. Thanks for the careful null-handling here - it was the right instinct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
