Kris20030907 opened a new pull request, #7362: URL: https://github.com/apache/rocketmq-dashboard/pull/7362
Closes #7361 `pushAclToBroker` used to read a single repository page (200 rules) per account and discard the page `total`, so any rule past that page was silently dropped while the push still reported success. Changes: - `collectPushRules` now walks all repository pages for an account and feeds every stored rule to `buildPushPlan`. The walk ends when the reported total is covered; an empty page also ends it, so a total that overstates what the repository serves cannot spin the loop. - The page walk is safe against double reads: `findRulePage` orders by `(gmt_create desc, id desc)`, so page offsets are stable across fetches. - `MAX_RULES_PER_ACCOUNT` is renamed to `PUSH_RULE_PAGE_SIZE`: it was only the fetch page size of the single-page read, and nothing enforced or reported a 200-rule-per-account limit. - `pushAclToBroker` javadoc now states that every stored rule is read. Unchanged: `PushAclToBrokerResultVO` and the wire contract stay as they are — with every rule read, the push is complete and no truncation flag is needed. Rules the broker model cannot express are still reported per account via `skipped`, and per-broker outcomes are untouched. Tests: 2 new cases in `AclServiceTest` (rules spread over two pages are all pushed; a page walk bounded by an empty page when the total overstates), red before the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
