lizhimins commented on PR #5902: URL: https://github.com/apache/rocketmq-dashboard/pull/5902#issuecomment-6443338460
Merged as part of #5918 - squashed into `rocketmq-studio` as `2df0a70e1`. Your change here (adding a `sortOrder` to the total-lag sorter so unmeasured rows sink in both directions instead of landing at the top of a descending sort, following `compareResourceCounts` and `unmeasuredSortKey`. One scope note: this covers the total-lag column only. Your branch also touched `consumerConnections.ts`, but trunk has since replaced `onlineInstancesSortValue` with `onlineInstancesCount` (#6916, where an unavailable count renders as 0 by design), and your own merge of trunk had already dropped that part - so it is deliberately not included, and the commit body says so.) is included. We grouped 6 of your related fixes into a single commit so the trunk history stays reviewable; the other PRs in the group are closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change - the combined branch runs 4157 backend tests and 2016 frontend tests across 166 files green, with the build, type check, license and lint gates clean. Where the note above says "we", that part was added while landing the batch; the rest is yours unchanged. Thanks for the consistently well-tested patches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
