lizhimins commented on PR #6106: URL: https://github.com/apache/rocketmq-dashboard/pull/6106#issuecomment-6446483493
Merged as part of #5649 - squashed into `rocketmq-studio` as `aaf1d367c`. Your change here (making `group.detail`'s `delaySeconds` an `Integer` that is omitted when the delay cannot be measured, so the model is no longer told "0 seconds" as a fact. It follows `retryMaxTimes` in the same record, which is already a nullable Integer absent from `required`. We deliberately did **not** switch it to the `unavailable` wording #5291 introduced - that is the convention for prose, and this is a structured field. `catalog_gen.go` is regenerated once for this and #5649's `message.yaml` change together, and `make catalog-verify` reports no drift.) is included. We grouped 3 of your related fixes into a single commit so the trunk history stays reviewable; the other PR in the group is closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change - the combined branch runs 4161 backend tests and 2019 frontend tests green, with the catalog, license, type-check and lint gates clean. Where the note above says "we", that part was added while landing the batch; the rest is yours unchanged. Thanks for the carefully evidenced patches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
